package/kernel/mac80211/patches/rt2x00/023-rt2x00-do-not-print-error-when-queue-is-full.patch

   1 From patchwork Tue Mar 12 09:51:43 2019
   2 Content-Type: text/plain; charset="utf-8"
   3 MIME-Version: 1.0
   4 Content-Transfer-Encoding: 7bit
   5 X-Patchwork-Submitter: Stanislaw Gruszka <sgruszka@redhat.com>
   6 X-Patchwork-Id: 10848963
   7 X-Patchwork-Delegate: kvalo@adurom.com
   8 From: Stanislaw Gruszka <sgruszka@redhat.com>
   9 To: linux-wireless@vger.kernel.org
  10 Cc: =?utf-8?q?Tomislav_Po=C5=BEega?= <pozega.tomislav@gmail.com>,
  11  Daniel Golle <daniel@makrotopia.org>, Felix Fietkau <nbd@nbd.name>,
  12  Mathias Kresin <dev@kresin.me>
  13 Subject: [PATCH v3 4/4] rt2x00: do not print error when queue is full
  14 Date: Tue, 12 Mar 2019 10:51:43 +0100
  15 Message-Id: <1552384303-29529-5-git-send-email-sgruszka@redhat.com>
  16 In-Reply-To: <1552384303-29529-1-git-send-email-sgruszka@redhat.com>
  17 References: <1552384303-29529-1-git-send-email-sgruszka@redhat.com>
  18
  19 For unknown reasons printk() on some context can cause CPU hung on
  20 embedded MT7620 AP/router MIPS platforms. What can result on wifi
  21 disconnects.
  22
  23 This patch move queue full messages to debug level what is consistent
  24 with other mac80211 drivers which drop packet silently if tx queue is
  25 full. This make MT7620 OpenWRT routers more stable, what was reported
  26 by various users.
  27
  28 Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
  29 ---
  30  drivers/net/wireless/ralink/rt2x00/rt2x00queue.c | 2 +-
  31  1 file changed, 1 insertion(+), 1 deletion(-)
  32
  33 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
  34 +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
  35 @@ -671,7 +671,7 @@ int rt2x00queue_write_tx_frame(struct da
  36         spin_lock(&queue->tx_lock);
  37
  38         if (unlikely(rt2x00queue_full(queue))) {
  39 -               rt2x00_err(queue->rt2x00dev, "Dropping frame due to full tx queue %d\n",
  40 +               rt2x00_dbg(queue->rt2x00dev, "Dropping frame due to full tx queue %d\n",
  41                            queue->qid);
  42                 ret = -ENOBUFS;
  43                 goto out;