decode: function(s)
{
- var parts = s.split(/\s+/);
- if (parts.length < 2)
+ var parts = s.trim().match(/^((?:(?:^|,)[^ =,]+(?:=(?:[^ ",]+|"(?:[^"\\]|\\.)*"))?)+ +)?(ssh-dss|ssh-rsa|ssh-ed25519|ecdsa-sha2-nistp[0-9]+|sk-ecdsa-sha2-nistp256@openssh\.com|sk-ssh-ed25519@openssh\.com) +([^ ]+)( +.*)?$/);
+
+ if (!parts)
return null;
var key = null;
- try { key = atob(parts[1]); } catch(e) {}
+ try { key = atob(parts[3]); } catch(e) {}
if (!key)
return null;
return null;
var type = key.substr(off + 4, len);
- if (type !== parts[0])
+ if (type !== parts[2])
return null;
off += 4 + len;
if (len2 & 1)
len2--;
- var comment = parts.slice(2).join(' '),
- fprint = parts[1].length > 68 ? parts[1].substr(0, 33) + '…' + parts[1].substr(-34) : parts[1];
+ var comment = (parts[4] || '').trim(),
+ fprint = parts[3].length > 68 ? parts[3].substr(0, 33) + '…' + parts[3].substr(-34) : parts[3];
+
+ var options = null;
+ (parts[1] || '').trim().replace(/(?:^|,)([^ =,]+)(?:=(?:([^ ",]+)|"((?:[^"\\]|\\.)*)"))?/g, function(m, k, p, q) {
+ options = options || {};
+
+ if (options.hasOwnProperty(k))
+ options[k] += ',' + (q || p || true);
+ else
+ options[k] = (q || p || true);
+ });
switch (type)
{
case 'ssh-rsa':
- return { type: 'RSA', bits: len2 * 8, comment: comment, fprint: fprint };
+ return { type: 'RSA', bits: len2 * 8, comment: comment, options: options, fprint: fprint, src: s };
case 'ssh-dss':
- return { type: 'DSA', bits: len1 * 8, comment: comment, fprint: fprint };
+ return { type: 'DSA', bits: len1 * 8, comment: comment, options: options, fprint: fprint, src: s };
case 'ssh-ed25519':
- return { type: 'ECDH', curve: 'Curve25519', comment: comment, fprint: fprint };
+ return { type: 'EdDSA', curve: 'Curve25519', comment: comment, options: options, fprint: fprint, src: s };
case 'ecdsa-sha2':
- return { type: 'ECDSA', curve: curve, comment: comment, fprint: fprint };
+ return { type: 'ECDSA', curve: curve, comment: comment, options: options, fprint: fprint, src: s };
+
+ case 'sk-ecdsa-sha2-nistp256@openssh.com':
+ return { type: 'ECDSA-SK', curve: 'NIST P-256', comment: comment, options: options, fprint: fprint, src: s };
+
+ case 'sk-ssh-ed25519@openssh.com':
+ return { type: 'EdDSA-SK', curve: 'Curve25519', comment: comment, options: options, fprint: fprint, src: s };
default:
return null;
}
});
+function renderKeyItem(pubkey) {
+ return E('div', {
+ class: 'item',
+ click: isReadonlyView ? null : removeKey,
+ 'data-key': pubkey.src
+ }, [
+ E('strong', [ pubkey.comment || _('Unnamed key') ]), E('br'),
+ E('small', [
+ '%s, %s'.format(pubkey.type, pubkey.curve || _('%d Bit').format(pubkey.bits)),
+ pubkey.options ? E([], [
+ ' / ', _('Options:'), ' ',
+ E('code', Object.keys(pubkey.options).sort().join(', '))
+ ]) : '',
+ E('br'), E('code', pubkey.fprint)
+ ])
+ ]);
+}
+
function renderKeys(keys) {
var list = document.querySelector('.cbi-dynlist');
keys.forEach(function(key) {
var pubkey = SSHPubkeyDecoder.decode(key);
if (pubkey)
- list.insertBefore(E('div', {
- class: 'item',
- click: removeKey,
- 'data-key': key
- }, [
- E('strong', pubkey.comment || _('Unnamed key')), E('br'),
- E('small', [
- '%s, %s'.format(pubkey.type, pubkey.curve || _('%d Bit').format(pubkey.bits)),
- E('br'), E('code', pubkey.fprint)
- ])
- ]), list.lastElementChild);
+ list.insertBefore(renderKeyItem(pubkey), list.lastElementChild);
});
if (list.firstElementChild === list.lastElementChild)
}
else if (!pubkey) {
ui.showModal(_('Add key'), [
- E('div', { class: 'alert-message warning' }, _('The given SSH public key is invalid. Please supply proper public RSA or ECDSA keys.')),
+ E('div', { class: 'alert-message warning' }, _('The given SSH public key is invalid. Please supply proper public RSA, ED25519 or ECDSA keys.')),
E('div', { class: 'right' }, E('div', { class: 'btn', click: L.hideModal }, _('Close')))
]);
}
input.value = '';
return saveKeys(keys).then(function() {
- var added = list.querySelector('[data-key="%s"]'.format(key));
+ var added = list.querySelector('[data-key="%s"]'.format(key.replace(/["\\]/g, '\\$&')));
if (added)
added.classList.add('flash');
});
L.showModal(_('Delete key'), [
E('div', _('Do you really want to delete the following SSH key?')),
- E('pre', delkey),
+ E('pre', [ delkey ]),
E('div', { class: 'right' }, [
E('div', { class: 'btn', click: L.hideModal }, _('Cancel')),
' ',
return view.extend({
load: function() {
return fs.lines('/etc/dropbear/authorized_keys').then(function(lines) {
- return lines.filter(function(line) {
- return line.match(/^(ssh-rsa|ssh-dss|ssh-ed25519|ecdsa-sha2)\b/) != null;
+ return lines.map(function(line) {
+ return SSHPubkeyDecoder.decode(line);
+ }).filter(function(line) {
+ return line != null;
});
});
},
])
]);
- keys.forEach(L.bind(function(key) {
- var pubkey = SSHPubkeyDecoder.decode(key);
- if (pubkey)
- list.insertBefore(E('div', {
- class: 'item',
- click: isReadonlyView ? null : ui.createHandlerFn(this, removeKey),
- 'data-key': key
- }, [
- E('strong', pubkey.comment || _('Unnamed key')), E('br'),
- E('small', [
- '%s, %s'.format(pubkey.type, pubkey.curve || _('%d Bit').format(pubkey.bits)),
- E('br'), E('code', pubkey.fprint)
- ])
- ]), list.lastElementChild);
+ keys.forEach(L.bind(function(pubkey) {
+ list.insertBefore(renderKeyItem(pubkey), list.lastElementChild);
}, this));
if (list.firstElementChild === list.lastElementChild)
return E('div', {}, [
E('h2', _('SSH-Keys')),
- E('div', { 'class': 'cbi-section-descr' }, _('Public keys allow for the passwordless SSH logins with a higher security compared to the use of plain passwords. In order to upload a new key to the device, paste an OpenSSH compatible public key line or drag a <code>.pub</code> file into the input field.')),
+ E('div', { 'class': 'cbi-section-descr' }, _('Public keys allow for passwordless SSH logins with higher security than plain passwords. In order to upload a new key to the device, paste an OpenSSH-compatible public key or drag a <code>.pub</code> file into the input field.')),
E('div', { 'class': 'cbi-section-node' }, list)
]);
},