snort3: improve script reliability

[feed/packages.git] / net / snort3 / files / snort-rules

diff --git a/net/snort3/files/snort-rules b/net/snort3/files/snort-rules
index 9547e9b4f17e01bced9b4e2b7955f4cd41fa7c5b..cc83833274735799ba736062bee54179ccd574dc 100644 (file)
--- a/net/snort3/files/snort-rules
+++ b/net/snort3/files/snort-rules
@@ -3,6 +3,8 @@
 # SPDX-License-Identifier: GPL-2.0
 # shellcheck disable=SC2039,SC2155  # "local" not defined in POSIX sh
 
+set -o nounset
+
 alias log='logger -s -t "snort-rules[$$]" -p "info"'
 
 download_rules() {
@@ -30,7 +32,7 @@ download_rules() {
                log "Generating testing rules..."
                archive_loc="testing-rules"
                new_rules="$data_dir/$archive_loc"
-               rm -fr "$new_rules"
+               rm -fr "${new_rules:?}"
                mkdir -p "$new_rules"
                rules_file="$new_rules/testing.rules"
                {
@@ -76,7 +78,7 @@ download_rules() {
 
                old_rules="$data_dir/old.rules"
                if $backup; then
-                       rm -fr "$old_rules"
+                       rm -fr "${old_rules:?}"
                        mkdir -p "$old_rules"
 
                        for rules_file in "$rules_dir"/*; do
@@ -103,7 +105,7 @@ download_rules() {
 
 
        mkdir -p "$conf_dir"
-       rm -fr "$rules_dir"
+       rm -fr "${rules_dir:?}"
        if $persist; then
                mv -f "$new_rules" "$rules_dir"
        else
@@ -145,7 +147,7 @@ USAGE
        exit 1
 }
 
-while [ -n "$1" ]; do
+while [ "${1:-}" ]; do
        case "$1" in
                -h|--help)
                        usage