ath79: fix ethernet setup for some qca953x devices
authorAdrian Schmutzler <freifunk@adrianschmutzler.de>
Wed, 12 Aug 2020 12:26:44 +0000 (14:26 +0200)
committerAdrian Schmutzler <freifunk@adrianschmutzler.de>
Tue, 25 Aug 2020 18:54:24 +0000 (20:54 +0200)
On Comfast CF-E130N v2 and Mikrotik LHG HB board, the config
found in DTS appears to be strange:

- eth0 has "syscon","simple-mfd" set although it's not enabled
- eth1 is enabled redundantly (already "okay" in qca953x.dtsi)
- phy-handle is set for eth1 in DTS although it has a fixed-link
  in qca953x.dtsi

This seems like a copy-paste gone wrong. Remove the named options.

Run-tested on MikroTik LHG 2.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
target/linux/ath79/dts/qca9531_comfast_cf-e130n-v2.dts
target/linux/ath79/dts/qca9533_mikrotik_routerboard-lhg-hb.dtsi

index a6ef6ad99c4cebdc2698854fa2b67d3f9833ee70..23551763561923badcaece8d2e367390d21e444e 100644 (file)
 
 &uart {
        status = "okay";
-
-};
-
-&eth0 {
-       compatible = "syscon", "simple-mfd";
 };
 
 &eth1 {
-       status = "okay";
-
-       phy-handle = <&swphy0>;
-
        mtd-mac-address = <&art 0x0>;
 
        gmac-config {
index 32cc6d3731f3907a8197029025fe1e90ad984b23..86249398c9ba163e65465707cfaa6ab99fd9e916 100644 (file)
        };
 };
 
-&eth0 {
-       compatible = "syscon", "simple-mfd";
-};
-
 &eth1 {
-       status = "okay";
-
-       phy-handle = <&swphy0>;
-
        gmac-config {
                device = <&gmac>;
        };