luci-app-aria2: fix incorrect "Extra Settings" section option name 3679/head
authorRaymond <raymond.wanyoike@gmail.com>
Tue, 25 Feb 2020 20:14:14 +0000 (23:14 +0300)
committerRaymond Wanyoike <raymond.wanyoike@gmail.com>
Tue, 25 Feb 2020 20:26:12 +0000 (23:26 +0300)
The "Extra Settings" section `extra_setting` option name does not match what
the `net/aria2` package expects.

See:

- https://github.com/openwrt/packages/blob/openwrt-19.07/net/aria2/files/aria2.init#L311
- https://github.com/openwrt/packages/blob/openwrt-19.07/net/aria2/files/aria2.conf#L31

Causing the luci UI "Extra Settings" option to have no effect. This fix
renames `extra_setting` => `extra_settings`.

Signed-off-by: Raymond Wanyoike <raymond.wanyoike@gmail.com>
applications/luci-app-aria2/luasrc/model/cbi/aria2/config.lua
applications/luci-app-aria2/root/etc/uci-defaults/40_luci-aria2

index 88068c13657f0765e235d1c49853f76f98c7828b..3927b1765e83d4bc05973becca7d8ce852902e46 100644 (file)
@@ -484,7 +484,7 @@ s = m:section(NamedSection, "main", "aria2", translate("Extra Settings"),
 s.addremove = false
 s.anonymous = true
 
-o = s:option(DynamicList, "extra_setting", translate("Settings list"),
+o = s:option(DynamicList, "extra_settings", translate("Settings list"),
        translate("List of extra settings. Format: option=value, eg. <code>netrc-path=/tmp/.netrc</code>."))
 o.placeholder = "option=value"
 
index 97ea9ca27cf1f09d06ec04300472b21b07bf66a1..becc1c699588aaef5146d4566870cb03ebdeed3a 100755 (executable)
@@ -9,7 +9,7 @@ if [ ."$(uci -q get aria2.main)" != ."aria2" ]; then
                set aria2.main.config_dir="/var/etc/aria2"
                add_list aria2.main.header=""
                add_list aria2.main.bt_tracker=""
-               add_list aria2.main.extra_setting=""
+               add_list aria2.main.extra_settings=""
                commit aria2
        EOF
 fi