luci-app-statistics: ping module, Update MaxMissed data type
authortew42 <2049715+tew42@users.noreply.github.com>
Sun, 2 Jan 2022 09:45:18 +0000 (11:45 +0200)
committerHannu Nyman <hannu.nyman@iki.fi>
Sun, 2 Jan 2022 09:45:18 +0000 (11:45 +0200)
MaxMissed was implemented with positive integers only, whereas I think it should also allow the option of "-1" (disabled state)

Signed-off-by: tew42 <2049715+tew42@users.noreply.github.com>
[slightly edited the proposed text]
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
applications/luci-app-statistics/htdocs/luci-static/resources/view/statistics/plugins/ping.js

index e08ff6497b570acb69ffd8f573002034255c191f..0c827e8a0b5a22af5360b72bedf7157ec2496e35 100644 (file)
@@ -34,9 +34,9 @@ return baseclass.extend({
                o.depends('enable', '1');
 
            o=s.option(form.Value,'MaxMissed',_('Maximum Missed Packets'),
-                      _('When a host has not replied to this number of packets in a row, re-resolve the hostname in DNS.  Useful for dynamic DNS hosts.'));
-               o.placeholder = '10';
-               o.datatype = 'uinteger';
+                      _('When a host has not replied to this number of packets in a row, re-resolve the hostname in DNS.  Useful for dynamic DNS hosts.  Default is -1 = disabled.'));
+               o.placeholder = '-1';
+               o.datatype = 'and(min(-1),integer)'
                o.optional = true;
                o.depends('enable', '1');
        },