xlat v2: Remove unused tlbi helper

xlat_arch_tlbi_va_regime() isn't used, so it has been renamed to
xlat_arch_tlbi_va() and the previous implementation has been removed.

Change-Id: Ic118bed3fb68234748d86b2e9e95b25650289276
Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com>

diff --git a/lib/xlat_tables_v2/aarch32/xlat_tables_arch.c b/lib/xlat_tables_v2/aarch32/xlat_tables_arch.c
index 2eae79c170ceebc8ac0abc429d84526dedbb788f..1e0a91d40cb23843c0b3dd502d9e97eca3235f55 100644 (file)
--- a/lib/xlat_tables_v2/aarch32/xlat_tables_arch.c
+++ b/lib/xlat_tables_v2/aarch32/xlat_tables_arch.c
@@ -55,18 +55,7 @@ uint64_t xlat_arch_regime_get_xn_desc(int xlat_regime __unused)
        return UPPER_ATTRS(XN);
 }
 
-void xlat_arch_tlbi_va(uintptr_t va)
-{
-       /*
-        * Ensure the translation table write has drained into memory before
-        * invalidating the TLB entry.
-        */
-       dsbishst();
-
-       tlbimvaais(TLBI_ADDR(va));
-}
-
-void xlat_arch_tlbi_va_regime(uintptr_t va, int xlat_regime __unused)
+void xlat_arch_tlbi_va(uintptr_t va, int xlat_regime __unused)
 {
        /*
         * Ensure the translation table write has drained into memory before

diff --git a/lib/xlat_tables_v2/aarch64/xlat_tables_arch.c b/lib/xlat_tables_v2/aarch64/xlat_tables_arch.c
index 40bf08a49e7637ca2b0309a390a3aa8e3f3d4413..e42762582c919e0fc0fa57a046ed95b453532de9 100644 (file)
--- a/lib/xlat_tables_v2/aarch64/xlat_tables_arch.c
+++ b/lib/xlat_tables_v2/aarch64/xlat_tables_arch.c
@@ -123,18 +123,7 @@ uint64_t xlat_arch_regime_get_xn_desc(int xlat_regime)
        }
 }
 
-void xlat_arch_tlbi_va(uintptr_t va)
-{
-#if IMAGE_EL == 1
-       assert(IS_IN_EL(1));
-       xlat_arch_tlbi_va_regime(va, EL1_EL0_REGIME);
-#elif IMAGE_EL == 3
-       assert(IS_IN_EL(3));
-       xlat_arch_tlbi_va_regime(va, EL3_REGIME);
-#endif
-}
-
-void xlat_arch_tlbi_va_regime(uintptr_t va, int xlat_regime)
+void xlat_arch_tlbi_va(uintptr_t va, int xlat_regime)
 {
        /*
         * Ensure the translation table write has drained into memory before

diff --git a/lib/xlat_tables_v2/xlat_tables_core.c b/lib/xlat_tables_v2/xlat_tables_core.c
index 30d7db8e894d93c16ea041a088415145d55846fa..104303a48533bb748ce75292a1d1e04c2f35a3aa 100644 (file)
--- a/lib/xlat_tables_v2/xlat_tables_core.c
+++ b/lib/xlat_tables_v2/xlat_tables_core.c
@@ -310,7 +310,7 @@ static void xlat_tables_unmap_region(xlat_ctx_t *ctx, mmap_region_t *mm,
                if (action == ACTION_WRITE_BLOCK_ENTRY) {
 
                        table_base[table_idx] = INVALID_DESC;
-                       xlat_arch_tlbi_va_regime(table_idx_va, ctx->xlat_regime);
+                       xlat_arch_tlbi_va(table_idx_va, ctx->xlat_regime);
 
                } else if (action == ACTION_RECURSE_INTO_TABLE) {
 
@@ -326,8 +326,8 @@ static void xlat_tables_unmap_region(xlat_ctx_t *ctx, mmap_region_t *mm,
                         */
                        if (xlat_table_is_empty(ctx, subtable)) {
                                table_base[table_idx] = INVALID_DESC;
-                               xlat_arch_tlbi_va_regime(table_idx_va,
-                                               ctx->xlat_regime);
+                               xlat_arch_tlbi_va(table_idx_va,
+                                                 ctx->xlat_regime);
                        }
 
                } else {

diff --git a/lib/xlat_tables_v2/xlat_tables_private.h b/lib/xlat_tables_v2/xlat_tables_private.h
index 1c3a729cf93db28978566f149e25e3451880df42..4661bb65678a44a4c7da87afa373480568fde030 100644 (file)
--- a/lib/xlat_tables_v2/xlat_tables_private.h
+++ b/lib/xlat_tables_v2/xlat_tables_private.h
@@ -45,18 +45,14 @@ uint64_t xlat_arch_regime_get_xn_desc(int xlat_regime);
  * Invalidate all TLB entries that match the given virtual address. This
  * operation applies to all PEs in the same Inner Shareable domain as the PE
  * that executes this function. This functions must be called for every
- * translation table entry that is modified.
- *
- * xlat_arch_tlbi_va() applies the invalidation to the exception level of the
- * current translation regime, whereas xlat_arch_tlbi_va_regime() applies it to
- * the given translation regime.
+ * translation table entry that is modified. It only affects the specified
+ * translation regime.
  *
  * Note, however, that it is architecturally UNDEFINED to invalidate TLB entries
  * pertaining to a higher exception level, e.g. invalidating EL3 entries from
  * S-EL1.
  */
-void xlat_arch_tlbi_va(uintptr_t va);
-void xlat_arch_tlbi_va_regime(uintptr_t va, int xlat_regime);
+void xlat_arch_tlbi_va(uintptr_t va, int xlat_regime);
 
 /*
  * This function has to be called at the end of any code that uses the function

diff --git a/lib/xlat_tables_v2/xlat_tables_utils.c b/lib/xlat_tables_v2/xlat_tables_utils.c
index fa375e672eb70f23d18834d58dfd57170ce50013..90a0a86269d5fa9f98cd1e5003e15c67484b00b8 100644 (file)
--- a/lib/xlat_tables_v2/xlat_tables_utils.c
+++ b/lib/xlat_tables_v2/xlat_tables_utils.c
@@ -543,7 +543,7 @@ int change_mem_attributes(xlat_ctx_t *ctx,
                *entry = INVALID_DESC;
 
                /* Invalidate any cached copy of this mapping in the TLBs. */
-               xlat_arch_tlbi_va_regime(base_va, ctx->xlat_regime);
+               xlat_arch_tlbi_va(base_va, ctx->xlat_regime);
 
                /* Ensure completion of the invalidation. */
                xlat_arch_tlbi_va_sync();