X-Git-Url: http://git.openwrt.org/?p=feed%2Frouting.git;a=blobdiff_plain;f=batman-adv%2Fpatches%2F0003-batman-adv-Hold-rtnl-lock-during-MTU-update-via-netl.patch;fp=batman-adv%2Fpatches%2F0003-batman-adv-Hold-rtnl-lock-during-MTU-update-via-netl.patch;h=0000000000000000000000000000000000000000;hp=4d7a3920eb493a9412646df04ebb37a15fe3433b;hb=f0f1b0a33ef3369dc7cabdbf1614ae7b48fc6b1e;hpb=601bd6c045a738bb465ab9b5444ddffb8951e0e6 diff --git a/batman-adv/patches/0003-batman-adv-Hold-rtnl-lock-during-MTU-update-via-netl.patch b/batman-adv/patches/0003-batman-adv-Hold-rtnl-lock-during-MTU-update-via-netl.patch deleted file mode 100644 index 4d7a392..0000000 --- a/batman-adv/patches/0003-batman-adv-Hold-rtnl-lock-during-MTU-update-via-netl.patch +++ /dev/null @@ -1,34 +0,0 @@ -From: Sven Eckelmann -Date: Mon, 21 Aug 2023 21:48:48 +0200 -Subject: batman-adv: Hold rtnl lock during MTU update via netlink - -The automatic recalculation of the maximum allowed MTU is usually triggered -by code sections which are already rtnl lock protected by callers outside -of batman-adv. But when the fragmentation setting is changed via -batman-adv's own batadv genl family, then the rtnl lock is not yet taken. - -But dev_set_mtu requires that the caller holds the rtnl lock because it -uses netdevice notifiers. And this code will then fail the check for this -lock: - - RTNL: assertion failed at net/core/dev.c (1953) - -Cc: stable@vger.kernel.org -Reported-by: syzbot+f8812454d9b3ac00d282@syzkaller.appspotmail.com -Fixes: 27c4d7c1c7fa ("batman-adv: Trigger events for auto adjusted MTU") -Reviewed-by: Simon Horman -Signed-off-by: Sven Eckelmann - ---- a/net/batman-adv/netlink.c -+++ b/net/batman-adv/netlink.c -@@ -495,7 +495,10 @@ static int batadv_netlink_set_mesh(struc - attr = info->attrs[BATADV_ATTR_FRAGMENTATION_ENABLED]; - - atomic_set(&bat_priv->fragmentation, !!nla_get_u8(attr)); -+ -+ rtnl_lock(); - batadv_update_min_mtu(bat_priv->soft_iface); -+ rtnl_unlock(); - } - - if (info->attrs[BATADV_ATTR_GW_BANDWIDTH_DOWN]) {