realtek: fix ZyXEL initramfs image generation
authorBjørn Mork <bjorn@mork.no>
Thu, 24 Jun 2021 21:04:08 +0000 (23:04 +0200)
committerChristian Lamparter <chunkeey@gmail.com>
Sat, 30 Oct 2021 13:00:22 +0000 (15:00 +0200)
commitdaefc646e6d4f1f730c5957b5954b88abe7c00f3
tree731ddb84bc6132319fd74d9d7f8cd84a54004f08
parent6102f883ce7f32988d22b7fc5b79356e3d06c1dc
realtek: fix ZyXEL initramfs image generation

The current rule produces empty trailers, causing the OEM firmware
update application to reject our images.

The double expansion of a makefile variable does not work inside
shell code.  The second round is interpreted as a shell expansion,
attempting to run the command ZYXEL_VERS instead of expanding the
$(ZYXEL_VERS) makefile variable.

Fix by removing one level of variable indirection.

Fixes: c6c8d597e183 ("realtek: Add generic zyxel_gs1900 image definition")
Tested-by: Sander Vanheule <sander@svanheule.net>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
target/linux/realtek/image/Makefile