ethtool: fix recursive dependency
authorEneas U de Queiroz <cotequeiroz@gmail.com>
Thu, 12 Aug 2021 13:57:07 +0000 (10:57 -0300)
committerHans Dedecker <dedeckeh@gmail.com>
Tue, 31 Aug 2021 18:35:19 +0000 (20:35 +0200)
commit4d0883c011e1f56711f59c2f18315d2cd817dba2
tree608cf77e52b1c4f2b84dc32e7f831e45e14dd564
parentbf94c2da3e60fe41b379cf4a7f87763d30fcb601
ethtool: fix recursive dependency

Change the CONFLICTS definition from the alternative package
(ethtool-full) to the main one.

The CONFLICTS line creates a dependency to the conflicting package.

Right now, the dependency would be created in the PACKAGE_ethtool-full
symbol:

config PACKAGE_ethtool-full
        depends on m || (PACKAGE_ethtool != y)

When the main package is selected by airmon-ng, it selects
PACKAGE_ethtool, *depending* on the value of PACKAGE_ethtool-full:

config PACKAGE_airmon-ng
        select PACKAGE_ethtool if PACKAGE_ethtool-full<PACKAGE_airmon-ng

In the first block, the value of PACKAGE_ethtool-full depends on the
value of PACKAGE_ethtool.  In the second block, the opposite is true:
the value of PACKAGE_ethtool depends on the value of
PACKAGE_ethtool-full.  This is a recursive dependency.

Fix it by changing the package where the dependency is created, so that
only the value of PACKAGE_ethtool will depend on PACKAGE_ethtool-full.

Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
package/network/utils/ethtool/Makefile