1 innetgr may not be there so make sure that when innetgr is not present
2 then we inform about it and not use it.
5 --- a/modules/pam_group/pam_group.c
6 +++ b/modules/pam_group/pam_group.c
7 @@ -656,7 +656,11 @@ static int check_account(pam_handle_t *p
9 /* If buffer starts with @, we are using netgroups */
12 good &= innetgr (&buffer[1], NULL, user, NULL);
14 + pam_syslog (pamh, LOG_ERR, "pam_group does not have netgroup support");
16 /* otherwise, if the buffer starts with %, it's a UNIX group */
17 else if (buffer[0] == '%')
18 good &= pam_modutil_user_in_group_nam_nam(pamh, user, &buffer[1]);
19 --- a/modules/pam_time/pam_time.c
20 +++ b/modules/pam_time/pam_time.c
21 @@ -555,9 +555,13 @@ check_account(pam_handle_t *pamh, const
23 /* If buffer starts with @, we are using netgroups */
25 - good &= innetgr (&buffer[1], NULL, user, NULL);
27 + good &= innetgr (&buffer[1], NULL, user, NULL);
29 + pam_syslog (pamh, LOG_ERR, "pam_time does not have netgroup support");
32 - good &= logic_field(pamh, user, buffer, count, is_same);
33 + good &= logic_field(pamh, user, buffer, count, is_same);
34 D(("with user: %s", good ? "passes":"fails" ));
36 /* here we get the time field */
37 --- a/modules/pam_succeed_if/pam_succeed_if.c
38 +++ b/modules/pam_succeed_if/pam_succeed_if.c
39 @@ -231,18 +231,27 @@ evaluate_notingroup(pam_handle_t *pamh,
41 /* Return PAM_SUCCESS if the (host,user) is in the netgroup. */
43 -evaluate_innetgr(const char *host, const char *user, const char *group)
44 +evaluate_innetgr(const pam_handle_t* pamh, const char *host, const char *user, const char *group)
47 if (innetgr(group, host, user, NULL) == 1)
50 + pam_syslog (pamh, LOG_ERR, "pam_succeed_if does not have netgroup support");
55 /* Return PAM_SUCCESS if the (host,user) is NOT in the netgroup. */
57 -evaluate_notinnetgr(const char *host, const char *user, const char *group)
58 +evaluate_notinnetgr(const pam_handle_t* pamh, const char *host, const char *user, const char *group)
61 if (innetgr(group, host, user, NULL) == 0)
64 + pam_syslog (pamh, LOG_ERR, "pam_succeed_if does not have netgroup support");
69 @@ -387,14 +396,14 @@ evaluate(pam_handle_t *pamh, int debug,
71 if (pam_get_item(pamh, PAM_RHOST, &rhost) != PAM_SUCCESS)
73 - return evaluate_innetgr(rhost, user, right);
74 + return evaluate_innetgr(pamh, rhost, user, right);
76 /* (Rhost, user) is not in this group. */
77 if (strcasecmp(qual, "notinnetgr") == 0) {
79 if (pam_get_item(pamh, PAM_RHOST, &rhost) != PAM_SUCCESS)
81 - return evaluate_notinnetgr(rhost, user, right);
82 + return evaluate_notinnetgr(pamh, rhost, user, right);
85 return PAM_SERVICE_ERR;