1 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
2 Date: Mon, 30 Jan 2017 16:09:51 +0100
3 Subject: [PATCH] brcmfmac: check brcmf_bus_get_memdump result for error
5 Content-Type: text/plain; charset=UTF-8
6 Content-Transfer-Encoding: 8bit
8 This method may be unsupported (see: USB bus) or may just fail (see:
10 While at it rework logic in brcmf_sdio_bus_get_memdump function to avoid
11 too many conditional code nesting levels.
13 Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
14 Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
15 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
18 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c
19 +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c
20 @@ -32,16 +32,25 @@ static int brcmf_debug_create_memdump(st
26 ramsize = brcmf_bus_get_ramsize(bus);
28 - dump = vzalloc(len + ramsize);
31 - memcpy(dump, data, len);
32 - brcmf_bus_get_memdump(bus, dump + len, ramsize);
33 - dev_coredumpv(bus->dev, dump, len + ramsize, GFP_KERNEL);
37 + dump = vzalloc(len + ramsize);
41 + memcpy(dump, data, len);
42 + err = brcmf_bus_get_memdump(bus, dump + len, ramsize);
48 + dev_coredumpv(bus->dev, dump, len + ramsize, GFP_KERNEL);