target/linux/at91/patches-5.10/187-ASoC-atmel-atmel-i2s-remove-useless-initialization.patch

   1 From e53725fe0c7e6b52927280272f49fe5f4b4ef317 Mon Sep 17 00:00:00 2001
   2 From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
   3 Date: Fri, 26 Mar 2021 16:59:13 -0500
   4 Subject: [PATCH 187/247] ASoC: atmel: atmel-i2s: remove useless initialization
   5
   6 Cppcheck complains:
   7
   8 sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization]
   9  err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
  10      ^
  11 sound/soc/atmel/atmel-i2s.c:598:10: note: err is initialized
  12  int err = -ENXIO;
  13          ^
  14 sound/soc/atmel/atmel-i2s.c:628:6: note: err is overwritten
  15  err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
  16      ^
  17
  18 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  19 Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
  20 Link: https://lore.kernel.org/r/20210326215927.936377-4-pierre-louis.bossart@linux.intel.com
  21 Signed-off-by: Mark Brown <broonie@kernel.org>
  22 ---
  23  sound/soc/atmel/atmel-i2s.c | 2 +-
  24  1 file changed, 1 insertion(+), 1 deletion(-)
  25
  26 diff --git a/sound/soc/atmel/atmel-i2s.c b/sound/soc/atmel/atmel-i2s.c
  27 index 7483c474ccd7..e7169c63becd 100644
  28 --- a/sound/soc/atmel/atmel-i2s.c
  29 +++ b/sound/soc/atmel/atmel-i2s.c
  30 @@ -613,7 +613,7 @@ static int atmel_i2s_probe(struct platform_device *pdev)
  31         struct regmap *regmap;
  32         void __iomem *base;
  33         int irq;
  34 -       int err = -ENXIO;
  35 +       int err;
  36         unsigned int pcm_flags = 0;
  37         unsigned int version;
  38
  39 --
  40 2.32.0
  41