1 From 28de437934da2fb9f04b0c4f5aa73553e63894e3 Mon Sep 17 00:00:00 2001
2 From: Maxime Ripard <maxime@cerno.tech>
3 Date: Mon, 21 Jun 2021 16:13:02 +0200
4 Subject: [PATCH] drm/vc4: crtc: Add some logging
6 The encoder retrieval code has been a source of bugs and glitches in the
7 past and the crtc <-> encoder association been wrong in a number of
10 Add some logging to quickly spot issues if they occur.
12 Signed-off-by: Maxime Ripard <maxime@cerno.tech>
14 drivers/gpu/drm/vc4/vc4_crtc.c | 6 ++++++
15 1 file changed, 6 insertions(+)
17 --- a/drivers/gpu/drm/vc4/vc4_crtc.c
18 +++ b/drivers/gpu/drm/vc4/vc4_crtc.c
19 @@ -543,6 +543,9 @@ static void vc4_crtc_atomic_disable(stru
20 struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, old_state);
21 struct drm_device *dev = crtc->dev;
23 + drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)",
24 + crtc->name, crtc->base.id, encoder->name, encoder->base.id);
26 require_hvs_enabled(dev);
28 /* Disable vblank irq handling before crtc is disabled. */
29 @@ -574,6 +577,9 @@ static void vc4_crtc_atomic_enable(struc
30 struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, new_state);
31 struct vc4_encoder *vc4_encoder = to_vc4_encoder(encoder);
33 + drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)",
34 + crtc->name, crtc->base.id, encoder->name, encoder->base.id);
36 require_hvs_enabled(dev);
38 /* Enable vblank irq handling before crtc is started otherwise