1 From 46773bdd99e4ab1bd0d65931ef782122f4f4a031 Mon Sep 17 00:00:00 2001
2 From: Dave Stevenson <dave.stevenson@raspberrypi.com>
3 Date: Sat, 12 Feb 2022 12:33:13 +0000
4 Subject: [PATCH] media: i2c: ov7251: Do not reset gain on mode change
6 There is no reaon why changing mode should reset the analogue
7 gain of the sensor, and it's not the behaviour that userspace
11 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
13 drivers/media/i2c/ov7251.c | 13 ++-----------
14 1 file changed, 2 insertions(+), 11 deletions(-)
16 --- a/drivers/media/i2c/ov7251.c
17 +++ b/drivers/media/i2c/ov7251.c
18 @@ -115,7 +115,6 @@ struct ov7251 {
20 struct v4l2_ctrl_handler ctrls;
21 struct v4l2_ctrl *exposure;
22 - struct v4l2_ctrl *gain;
23 struct v4l2_ctrl *hblank;
25 /* Cached register values */
26 @@ -1167,10 +1166,6 @@ static int ov7251_set_format(struct v4l2
30 - ret = __v4l2_ctrl_s_ctrl(ov7251->gain, 16);
34 ov7251->current_mode = new_mode;
37 @@ -1321,10 +1316,6 @@ static int ov7251_set_frame_interval(str
41 - ret = __v4l2_ctrl_s_ctrl(ov7251->gain, 16);
45 ov7251->current_mode = new_mode;
48 @@ -1550,8 +1541,8 @@ static int ov7251_probe(struct i2c_clien
49 V4L2_CID_VFLIP, 0, 1, 1, 0);
50 ov7251->exposure = v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops,
51 V4L2_CID_EXPOSURE, 1, 32, 1, 32);
52 - ov7251->gain = v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops,
53 - V4L2_CID_GAIN, 16, 1023, 1, 16);
54 + v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops, V4L2_CID_GAIN,
56 v4l2_ctrl_new_std_menu_items(&ov7251->ctrls, &ov7251_ctrl_ops,
57 V4L2_CID_TEST_PATTERN,
58 ARRAY_SIZE(ov7251_test_pattern_menu) - 1,