1 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
2 Date: Tue, 22 Jun 2021 07:05:04 +0200
3 Subject: [PATCH] net: broadcom: bcm4908_enet: reset DMA rings sw indexes
6 Content-Type: text/plain; charset=UTF-8
7 Content-Transfer-Encoding: 8bit
9 Resetting software indexes in bcm4908_dma_alloc_buf_descs() is not
10 enough as it's called during device probe only. Driver resets DMA on
11 every .ndo_open callback and it's required to reset indexes then.
13 This fixes inconsistent rings state and stalled traffic after interface
16 Fixes: 4feffeadbcb2 ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
17 Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
19 drivers/net/ethernet/broadcom/bcm4908_enet.c | 6 +++---
20 1 file changed, 3 insertions(+), 3 deletions(-)
22 --- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
23 +++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
24 @@ -174,9 +174,6 @@ static int bcm4908_dma_alloc_buf_descs(s
26 goto err_free_buf_descs;
29 - ring->write_idx = 0;
34 @@ -303,6 +300,9 @@ static void bcm4908_enet_dma_ring_init(s
36 enet_write(enet, ring->st_ram_block + ENET_DMA_CH_STATE_RAM_BASE_DESC_PTR,
37 (uint32_t)ring->dma_addr);
40 + ring->write_idx = 0;
43 static void bcm4908_enet_dma_uninit(struct bcm4908_enet *enet)