target/linux/bcm53xx/patches-5.10/320-ARM-dts-BCM5301X-Switch-back-to-old-clock-nodes-name.patch

   1 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
   2 Date: Tue, 23 Nov 2021 13:13:05 +0100
   3 Subject: [PATCH] ARM: dts: BCM5301X: Switch back to old clock nodes names
   4 MIME-Version: 1.0
   5 Content-Type: text/plain; charset=UTF-8
   6 Content-Transfer-Encoding: 8bit
   7
   8 First of all using the same node name prefix resulted in trying to
   9 register 2 clocks under the same "clock-controller" name:
  10
  11 [    0.000000] __clk_core_init: clk clock-controller already initialized
  12 [    0.000000] ------------[ cut here ]------------
  13 [    0.000000] WARNING: CPU: 0 PID: 0 at drivers/clk/bcm/clk-iproc-pll.c:802 iproc_pll_clk_setup+0x4c8/0x4f4
  14 [    0.000000] Modules linked in:
  15 [    0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.10.80 #0
  16 [    0.000000] Hardware name: BCM5301X
  17 [    0.000000] [<c0108410>] (unwind_backtrace) from [<c0104bc4>] (show_stack+0x10/0x14)
  18 [    0.000000] [<c0104bc4>] (show_stack) from [<c03dca28>] (dump_stack+0x94/0xa8)
  19 [    0.000000] [<c03dca28>] (dump_stack) from [<c0118440>] (__warn+0xb8/0x114)
  20 [    0.000000] [<c0118440>] (__warn) from [<c0118504>] (warn_slowpath_fmt+0x68/0x78)
  21 [    0.000000] [<c0118504>] (warn_slowpath_fmt) from [<c043281c>] (iproc_pll_clk_setup+0x4c8/0x4f4)
  22 [    0.000000] [<c043281c>] (iproc_pll_clk_setup) from [<c0818c04>] (nsp_genpll_clk_init+0x30/0x38)
  23 [    0.000000] [<c0818c04>] (nsp_genpll_clk_init) from [<c0818634>] (of_clk_init+0x118/0x1f8)
  24 [    0.000000] [<c0818634>] (of_clk_init) from [<c08039b0>] (time_init+0x24/0x30)
  25 [    0.000000] [<c08039b0>] (time_init) from [<c0800d14>] (start_kernel+0x398/0x50c)
  26 [    0.000000] [<c0800d14>] (start_kernel) from [<00000000>] (0x0)
  27 [    0.000000] ---[ end trace fe236bfe9559ee50 ]---
  28
  29 Secondly using any other names than "lcpll0" and "genpll" breaks output
  30 clocks:
  31
  32 $ cat /sys/kernel/debug/clk/usbclk/clk_rate
  33 0
  34
  35 For some reason iproc_clk_recalc_rate() gets called with "parent_rate"
  36 argument 0 whenever clocks aren't named "lcpll0" and "genpll".
  37
  38 Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
  39 ---
  40  arch/arm/boot/dts/bcm5301x.dtsi | 4 ++--
  41  1 file changed, 2 insertions(+), 2 deletions(-)
  42
  43 --- a/arch/arm/boot/dts/bcm5301x.dtsi
  44 +++ b/arch/arm/boot/dts/bcm5301x.dtsi
  45 @@ -421,7 +421,7 @@
  46                         #address-cells = <1>;
  47                         #size-cells = <1>;
  48
  49 -                       lcpll0: clock-controller@100 {
  50 +                       lcpll0: lcpll0@100 {
  51                                 #clock-cells = <1>;
  52                                 compatible = "brcm,nsp-lcpll0";
  53                                 reg = <0x100 0x14>;
  54 @@ -430,7 +430,7 @@
  55                                                      "sdio", "ddr_phy";
  56                         };
  57
  58 -                       genpll: clock-controller@140 {
  59 +                       genpll: genpll@140 {
  60                                 #clock-cells = <1>;
  61                                 compatible = "brcm,nsp-genpll";
  62                                 reg = <0x140 0x24>;