1 From 827e46013755254e526f0b682495ee88066a05a3 Mon Sep 17 00:00:00 2001
2 From: Phil Elwell <phil@raspberrypi.org>
3 Date: Wed, 23 Mar 2016 20:53:47 +0000
4 Subject: [PATCH] vchiq_arm: Service callbacks must not fail
6 Service callbacks are not allowed to return an error. The internal callback
7 that delivers events and messages to user tasks does not enqueue them if
8 the service is closing, but this is not an error and should not be
11 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
13 drivers/misc/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
14 1 file changed, 1 insertion(+), 1 deletion(-)
16 --- a/drivers/misc/vc04_services/interface/vchiq_arm/vchiq_arm.c
17 +++ b/drivers/misc/vc04_services/interface/vchiq_arm/vchiq_arm.c
18 @@ -224,7 +224,7 @@ add_completion(VCHIQ_INSTANCE_T instance
19 } else if (instance->closing) {
20 vchiq_log_info(vchiq_arm_log_level,
21 "service_callback closing");
23 + return VCHIQ_SUCCESS;
25 DEBUG_TRACE(SERVICE_CALLBACK_LINE);