1 From aed8fdad2152d946add50bec00a6b07c457bdcdf Mon Sep 17 00:00:00 2001
2 From: Alexander Stein <alexander.stein@ew.tq-group.com>
3 Date: Mon, 24 Apr 2023 16:16:48 +0200
4 Subject: [PATCH] net: phy: Fix reading LED reg property
6 'reg' is always encoded in 32 bits, thus it has to be read using the
7 function with the corresponding bit width.
9 Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs")
10 Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
11 Reviewed-by: Andrew Lunn <andrew@lunn.ch>
12 Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
13 Link: https://lore.kernel.org/r/20230424141648.317944-1-alexander.stein@ew.tq-group.com
14 Signed-off-by: Jakub Kicinski <kuba@kernel.org>
16 drivers/net/phy/phy_device.c | 6 +++++-
17 1 file changed, 5 insertions(+), 1 deletion(-)
19 --- a/drivers/net/phy/phy_device.c
20 +++ b/drivers/net/phy/phy_device.c
21 @@ -2971,6 +2971,7 @@ static int of_phy_led(struct phy_device
22 struct led_init_data init_data = {};
23 struct led_classdev *cdev;
24 struct phy_led *phyled;
28 phyled = devm_kzalloc(dev, sizeof(*phyled), GFP_KERNEL);
29 @@ -2980,10 +2981,13 @@ static int of_phy_led(struct phy_device
30 cdev = &phyled->led_cdev;
31 phyled->phydev = phydev;
33 - err = of_property_read_u8(led, "reg", &phyled->index);
34 + err = of_property_read_u32(led, "reg", &index);
40 + phyled->index = index;
41 if (phydev->drv->led_brightness_set)
42 cdev->brightness_set_blocking = phy_led_set_brightness;
43 if (phydev->drv->led_blink_set)