node: move roam-events to dedicated struct
[project/usteer.git] / ubus.c
diff --git a/ubus.c b/ubus.c
index bc328f3c4cf916407f9f4090a29d1fd724aaaa43..768c9cf03b022bc4e2c7e74f135bf7d3b461bfdb 100644 (file)
--- a/ubus.c
+++ b/ubus.c
@@ -142,9 +142,11 @@ struct cfg_item {
 #define __config_items \
        _cfg(BOOL, syslog), \
        _cfg(U32, debug_level), \
+       _cfg(BOOL, ipv6), \
        _cfg(U32, sta_block_timeout), \
        _cfg(U32, local_sta_timeout), \
        _cfg(U32, local_sta_update), \
+       _cfg(U32, max_neighbor_reports), \
        _cfg(U32, max_retry_band), \
        _cfg(U32, seen_policy_timeout), \
        _cfg(U32, load_balancing_threshold), \
@@ -153,6 +155,7 @@ struct cfg_item {
        _cfg(BOOL, assoc_steering), \
        _cfg(I32, min_connect_snr), \
        _cfg(I32, min_snr), \
+       _cfg(U32, roam_process_timeout), \
        _cfg(I32, roam_scan_snr), \
        _cfg(U32, roam_scan_tries), \
        _cfg(U32, roam_scan_interval), \
@@ -264,30 +267,51 @@ usteer_ubus_set_config(struct ubus_context *ctx, struct ubus_object *obj,
                }
        }
 
+       usteer_interface_init();
+
        return 0;
 }
 
-static void
-usteer_dump_node(struct usteer_node *node)
+void usteer_dump_node(struct blob_buf *buf, struct usteer_node *node)
 {
-       void *c;
+       void *c, *roam_events;
+
+       c = blobmsg_open_table(buf, usteer_node_name(node));
+       blobmsg_printf(buf, "bssid", MAC_ADDR_FMT, MAC_ADDR_DATA(node->bssid));
+       blobmsg_add_u32(buf, "freq", node->freq);
+       blobmsg_add_u32(buf, "n_assoc", node->n_assoc);
+       blobmsg_add_u32(buf, "noise", node->noise);
+       blobmsg_add_u32(buf, "load", node->load);
+       blobmsg_add_u32(buf, "max_assoc", node->max_assoc);
+
+       roam_events = blobmsg_open_table(buf, "roam_events");
+       blobmsg_add_u32(buf, "source", node->roam_events.source);
+       blobmsg_add_u32(buf, "target", node->roam_events.target);
+       blobmsg_close_table(buf, roam_events);
 
-       c = blobmsg_open_table(&b, usteer_node_name(node));
-       blobmsg_add_u32(&b, "freq", node->freq);
-       blobmsg_add_u32(&b, "n_assoc", node->n_assoc);
-       blobmsg_add_u32(&b, "noise", node->noise);
-       blobmsg_add_u32(&b, "load", node->load);
-       blobmsg_add_u32(&b, "max_assoc", node->max_assoc);
        if (node->rrm_nr)
-               blobmsg_add_field(&b, BLOBMSG_TYPE_ARRAY, "rrm_nr",
+               blobmsg_add_field(buf, BLOBMSG_TYPE_ARRAY, "rrm_nr",
                                  blobmsg_data(node->rrm_nr),
                                  blobmsg_data_len(node->rrm_nr));
        if (node->node_info)
-               blobmsg_add_field(&b, BLOBMSG_TYPE_TABLE, "node_info",
+               blobmsg_add_field(buf, BLOBMSG_TYPE_TABLE, "node_info",
                                  blob_data(node->node_info),
                                  blob_len(node->node_info));
 
-       blobmsg_close_table(&b, c);
+       blobmsg_close_table(buf, c);
+}
+
+void usteer_dump_host(struct blob_buf *buf, struct usteer_remote_host *host)
+{
+       void *c;
+
+       c = blobmsg_open_table(buf, host->addr);
+       blobmsg_add_u32(buf, "id", (uint32_t)(uintptr_t)host->avl.key);
+       if (host->host_info)
+               blobmsg_add_field(buf, BLOBMSG_TYPE_TABLE, "host_info",
+                                 blobmsg_data(host->host_info),
+                                 blobmsg_len(host->host_info));
+       blobmsg_close_table(buf, c);
 }
 
 static int
@@ -300,7 +324,7 @@ usteer_ubus_local_info(struct ubus_context *ctx, struct ubus_object *obj,
        blob_buf_init(&b, 0);
 
        for_each_local_node(node)
-               usteer_dump_node(node);
+               usteer_dump_node(&b, node);
 
        ubus_send_reply(ctx, req, b.head);
 
@@ -313,19 +337,11 @@ usteer_ubus_remote_hosts(struct ubus_context *ctx, struct ubus_object *obj,
                         struct blob_attr *msg)
 {
        struct usteer_remote_host *host;
-       void *c;
 
        blob_buf_init(&b, 0);
 
-       avl_for_each_element(&remote_hosts, host, avl) {
-               c = blobmsg_open_table(&b, host->addr);
-               blobmsg_add_u32(&b, "id", (uint32_t)(uintptr_t)host->avl.key);
-               if (host->host_info)
-                       blobmsg_add_field(&b, BLOBMSG_TYPE_TABLE, "host_info",
-                                         blobmsg_data(host->host_info),
-                                         blobmsg_len(host->host_info));
-               blobmsg_close_table(&b, c);
-       }
+       avl_for_each_element(&remote_hosts, host, avl)
+               usteer_dump_host(&b, host);
 
        ubus_send_reply(ctx, req, b.head);
 
@@ -342,7 +358,7 @@ usteer_ubus_remote_info(struct ubus_context *ctx, struct ubus_object *obj,
        blob_buf_init(&b, 0);
 
        for_each_remote_node(rn)
-               usteer_dump_node(&rn->node);
+               usteer_dump_node(&b, &rn->node);
 
        ubus_send_reply(ctx, req, b.head);
 
@@ -462,7 +478,7 @@ struct ubus_object usteer_obj = {
        .n_methods = ARRAY_SIZE(usteer_methods),
 };
 
-static void
+static bool
 usteer_add_nr_entry(struct usteer_node *ln, struct usteer_node *node)
 {
        struct blobmsg_policy policy[3] = {
@@ -473,38 +489,61 @@ usteer_add_nr_entry(struct usteer_node *ln, struct usteer_node *node)
        struct blob_attr *tb[3];
 
        if (!node->rrm_nr)
-               return;
+               return false;
 
        if (strcmp(ln->ssid, node->ssid) != 0)
-               return;
+               return false;
 
        blobmsg_parse_array(policy, ARRAY_SIZE(tb), tb,
                            blobmsg_data(node->rrm_nr),
                            blobmsg_data_len(node->rrm_nr));
        if (!tb[2])
-               return;
+               return false;
 
        blobmsg_add_field(&b, BLOBMSG_TYPE_STRING, "",
                          blobmsg_data(tb[2]),
                          blobmsg_data_len(tb[2]));
+       
+       return true;
+}
+
+static void
+usteer_ubus_disassoc_add_neighbors(struct sta_info *si)
+{
+       struct usteer_node *node, *last_remote_neighbor = NULL;
+       int i = 0;
+       void *c;
+
+       c = blobmsg_open_array(&b, "neighbors");
+       for_each_local_node(node) {
+               if (i >= config.max_neighbor_reports)
+                       break;
+               if (usteer_add_nr_entry(si->node, node))
+                       i++;
+       }
+
+       while (i < config.max_neighbor_reports) {
+               node = usteer_node_get_next_neighbor(si->node, last_remote_neighbor);
+               if (!node) {
+                       /* No more nodes available */
+                       break;
+               }
+
+               last_remote_neighbor = node;
+               if (usteer_add_nr_entry(si->node, node))
+                       i++;
+       }
+       blobmsg_close_array(&b, c);
 }
 
 int usteer_ubus_notify_client_disassoc(struct sta_info *si)
 {
        struct usteer_local_node *ln = container_of(si->node, struct usteer_local_node, node);
-       struct usteer_remote_node *rn;
-       struct usteer_node *node;
-       void *c;
 
        blob_buf_init(&b, 0);
        blobmsg_printf(&b, "addr", MAC_ADDR_FMT, MAC_ADDR_DATA(si->sta->addr));
        blobmsg_add_u32(&b, "duration", config.roam_kick_delay);
-       c = blobmsg_open_array(&b, "neighbors");
-       for_each_local_node(node)
-               usteer_add_nr_entry(si->node, node);
-       for_each_remote_node(rn)
-               usteer_add_nr_entry(si->node, &rn->node);
-       blobmsg_close_array(&b, c);
+       usteer_ubus_disassoc_add_neighbors(si);
        return ubus_invoke(ubus_ctx, ln->obj_id, "wnm_disassoc_imminent", b.head, NULL, 0, 100);
 }
 
@@ -512,13 +551,18 @@ int usteer_ubus_trigger_client_scan(struct sta_info *si)
 {
        struct usteer_local_node *ln = container_of(si->node, struct usteer_local_node, node);
 
+       if (!usteer_sta_supports_beacon_measurement_mode(si->sta, BEACON_MEASUREMENT_ACTIVE)) {
+               MSG(DEBUG, "STA does not support beacon measurement sta=" MAC_ADDR_FMT "\n", MAC_ADDR_DATA(si->sta->addr));
+               return 0;
+       }
+
        si->scan_band = !si->scan_band;
 
        blob_buf_init(&b, 0);
        blobmsg_printf(&b, "addr", MAC_ADDR_FMT, MAC_ADDR_DATA(si->sta->addr));
-       blobmsg_add_u32(&b, "mode", 1);
-       blobmsg_add_u32(&b, "duration", 65535);
-       blobmsg_add_u32(&b, "channel", 255);
+       blobmsg_add_u32(&b, "mode", BEACON_MEASUREMENT_ACTIVE);
+       blobmsg_add_u32(&b, "duration", config.roam_scan_interval / 100);
+       blobmsg_add_u32(&b, "channel", 0);
        blobmsg_add_u32(&b, "op_class", si->scan_band ? 1 : 12);
        return ubus_invoke(ubus_ctx, ln->obj_id, "rrm_beacon_req", b.head, NULL, 0, 100);
 }
@@ -532,7 +576,7 @@ void usteer_ubus_kick_client(struct sta_info *si)
        blobmsg_add_u32(&b, "reason", config.load_kick_reason_code);
        blobmsg_add_u8(&b, "deauth", 1);
        ubus_invoke(ubus_ctx, ln->obj_id, "del_client", b.head, NULL, 0, 100);
-       si->connected = 0;
+       si->connected = STA_NOT_CONNECTED;
        si->roam_kick = current_time;
 }