if (uh->ssl)
ustream_free(&uh->ussl.stream);
ustream_free(&uh->ufd.stream);
- close(uh->ufd.fd.fd);
+ if(uh->ufd.fd.fd)
+ close(uh->ufd.fd.fd);
uh->us = NULL;
}
return;
}
- if (uh->content_length < 0 && uh->read_chunked >= 0)
+ if ((uh->content_length < 0 && uh->read_chunked >= 0) ||
+ uh->content_length == 0)
uh->uc.data_eof = true;
uclient_backend_set_eof(&uh->uc);
struct uclient_url *url = uh->uc.url;
const char *realm = NULL, *opaque = NULL;
const char *user, *password;
- char *buf, *next, *buf_orig;
+ char *buf, *next;
int len, ofs;
int err = 0;
strcpy(buf, uh->auth_str);
/* skip auth type */
- buf_orig = strsep(&buf, " ");
+ strsep(&buf, " ");
next = buf;
while (*next) {
if (!realm || !data.qop || !data.nonce) {
err = -EINVAL;
- goto fail_buf;
+ goto fail;
}
sprintf(nc_str, "%08x", uh->nc++);
len = password - url->auth;
if (len > 256) {
err = -EINVAL;
- goto fail_buf;
+ goto fail;
}
user_buf = alloca(len + 1);
if (!user_buf) {
err = -ENOMEM;
- goto fail_buf;
+ goto fail;
}
strncpy(user_buf, url->auth, len);
return 0;
-fail_buf:
- free(buf_orig);
fail:
return err;
}
struct blob_attr *cur;
enum request_type req_type = uh->req_type;
bool literal_ipv6;
- int err, rem;
+ int err;
+ size_t rem;
if (uh->state >= HTTP_STATE_HEADERS_SENT)
return 0;
uclient_http_set_request_type(struct uclient *cl, const char *type)
{
struct uclient_http *uh = container_of(cl, struct uclient_http, uc);
- int i;
+ unsigned int i;
if (cl->backend != &uclient_backend_http)
return -1;
}
}
- if (len > data_end - data)
- len = data_end - data;
+ unsigned int diff = data_end - data;
+ if (len > diff)
+ len = diff;
if (uh->read_chunked >= 0) {
- if (len > uh->read_chunked)
+ if (len > (unsigned long) uh->read_chunked)
len = uh->read_chunked;
uh->read_chunked -= len;
} else if (uh->content_length >= 0) {
- if (len > uh->content_length)
+ if (len > (unsigned long) uh->content_length)
len = uh->content_length;
uh->content_length -= len;
if (!url)
return false;
- free(cl->url);
- cl->url = url;
+ if (cl->proxy_url) {
+ free(cl->proxy_url);
+ cl->proxy_url = url;
+ }
+ else {
+ free(cl->url);
+ cl->url = url;
+ }
+
if (uclient_http_connect(cl))
return -1;