X-Git-Url: http://git.openwrt.org/?a=blobdiff_plain;f=alias.c;h=98d54100fef9294eae187275b934850a3a054098;hb=33ec3daaaa52cea628df91eb0eb1701e16172c1e;hp=e4bb700fb216f61ae81b4f76a630749c11ef1de4;hpb=6fd6be6b7f3fc4883fdc464fcbcb2b5e8d8e8174;p=project%2Fnetifd.git

diff --git a/alias.c b/alias.c
index e4bb700..98d5410 100644
--- a/alias.c
+++ b/alias.c
@@ -30,8 +30,6 @@ struct alias_device {
 	char name[];
 };
 
-static const struct device_type alias_device_type;
-
 static void alias_set_device(struct alias_device *alias, struct device *dev)
 {
 	if (dev == alias->dep.dev) {
@@ -59,12 +57,11 @@ static void alias_set_device(struct alias_device *alias, struct device *dev)
 	alias->dev.hidden = !dev;
 	if (dev) {
 		device_set_ifindex(&alias->dev, dev->ifindex);
-		strcpy(alias->dev.ifname, dev->ifname);
-		device_broadcast_event(&alias->dev, DEV_EVENT_UPDATE_IFNAME);
+		device_set_ifname(&alias->dev, dev->ifname);
 		device_add_user(&alias->dep, dev);
 	} else {
-		alias->dev.ifname[0] = 0;
-		device_broadcast_event(&alias->dev, DEV_EVENT_UPDATE_IFNAME);
+		device_set_ifname(&alias->dev, "");
+		device_set_link(&alias->dev, false);
 	}
 }
 
@@ -90,19 +87,20 @@ alias_device_set_state(struct device *dev, bool state)
 static void alias_device_cb(struct device_user *dep, enum device_event ev)
 {
 	struct alias_device *alias;
-	bool new_state = false;
 
 	alias = container_of(dep, struct alias_device, dep);
 	switch (ev) {
 	case DEV_EVENT_ADD:
-		new_state = true;
+		device_set_present(&alias->dev, true);
+		break;
 	case DEV_EVENT_REMOVE:
-		device_set_present(&alias->dev, new_state);
+		device_set_present(&alias->dev, false);
 		break;
 	case DEV_EVENT_LINK_UP:
-		new_state = true;
+		device_set_link(&alias->dev, true);
+		break;
 	case DEV_EVENT_LINK_DOWN:
-		device_set_link(&alias->dev, new_state);
+		device_set_link(&alias->dev, false);
 		break;
 	case DEV_EVENT_UPDATE_IFINDEX:
 		device_set_ifindex(&alias->dev, dep->dev->ifindex);
@@ -114,7 +112,8 @@ static void alias_device_cb(struct device_user *dep, enum device_event ev)
 }
 
 static struct device *
-alias_device_create(const char *name, struct blob_attr *attr)
+alias_device_create(const char *name, struct device_type *devtype,
+		    struct blob_attr *attr)
 {
 	struct alias_device *alias;
 
@@ -125,7 +124,11 @@ alias_device_create(const char *name, struct blob_attr *attr)
 	strcpy(alias->name, name);
 	alias->dev.set_state = alias_device_set_state;
 	alias->dev.hidden = true;
-	device_init_virtual(&alias->dev, &alias_device_type, NULL);
+	if (device_init_virtual(&alias->dev, devtype, NULL) < 0) {
+		free(alias);
+		return NULL;
+	}
+
 	alias->avl.key = alias->name;
 	avl_insert(&aliases, &alias->avl);
 	alias->dep.alias = true;
@@ -163,7 +166,7 @@ static int alias_check_state(struct device *dev)
 	return 0;
 }
 
-static const struct device_type alias_device_type = {
+static struct device_type alias_device_type = {
 	.name = "Network alias",
 	.create = alias_device_create,
 	.free = alias_device_free,
@@ -175,13 +178,9 @@ alias_notify_device(const char *name, struct device *dev)
 {
 	struct alias_device *alias;
 
-	device_lock();
-
 	alias = avl_find_element(&aliases, name, alias, avl);
 	if (alias)
 		alias_set_device(alias, dev);
-
-	device_unlock();
 }
 
 struct device *
@@ -193,7 +192,7 @@ device_alias_get(const char *name)
 	if (alias)
 		return &alias->dev;
 
-	return alias_device_create(name, NULL);
+	return alias_device_create(name, &alias_device_type, NULL);
 }
 
 static void __init alias_init(void)