X-Git-Url: http://git.openwrt.org/?a=blobdiff_plain;f=target%2Flinux%2Fbrcm2708%2Fpatches-4.19%2F950-0262-staging-bcm2835-camera-Correct-V4L2_CID_COLORFX_CBCR.patch;fp=target%2Flinux%2Fbrcm2708%2Fpatches-4.19%2F950-0262-staging-bcm2835-camera-Correct-V4L2_CID_COLORFX_CBCR.patch;h=0000000000000000000000000000000000000000;hb=67dcc43f3a22dc3a7ac07a7065971b426feeb043;hp=21cbfca0a44efb630cb6b8d40f8c4e9aeb013940;hpb=47a93a810f78adce5a130d287f82b28e9b54313c;p=openwrt%2Fstaging%2Fchunkeey.git diff --git a/target/linux/brcm2708/patches-4.19/950-0262-staging-bcm2835-camera-Correct-V4L2_CID_COLORFX_CBCR.patch b/target/linux/brcm2708/patches-4.19/950-0262-staging-bcm2835-camera-Correct-V4L2_CID_COLORFX_CBCR.patch deleted file mode 100644 index 21cbfca0a4..0000000000 --- a/target/linux/brcm2708/patches-4.19/950-0262-staging-bcm2835-camera-Correct-V4L2_CID_COLORFX_CBCR.patch +++ /dev/null @@ -1,34 +0,0 @@ -From f07147faddeb0e99bfe181af78fcda9ea7f06c3d Mon Sep 17 00:00:00 2001 -From: Dave Stevenson -Date: Mon, 8 Oct 2018 18:26:15 +0100 -Subject: [PATCH 262/806] staging: bcm2835-camera: Correct - V4L2_CID_COLORFX_CBCR behaviour - -With V4L2_CID_COLORFX_CBCR calling ctrl_set_colfx it was incorrectly -assigning the colour values to the enable field of dev->colourfx -instead of the u and v fields. - -Correct the assignments. - -Reported as a Coverity issue -Detected by CoverityScan CID#1419711 ("Unused value") - -Reported-by: Colin Ian King -Signed-off-by: Dave Stevenson ---- - drivers/staging/vc04_services/bcm2835-camera/controls.c | 4 ++-- - 1 file changed, 2 insertions(+), 2 deletions(-) - ---- a/drivers/staging/vc04_services/bcm2835-camera/controls.c -+++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c -@@ -578,8 +578,8 @@ static int ctrl_set_colfx(struct bm2835_ - - control = &dev->component[COMP_CAMERA]->control; - -- dev->colourfx.enable = (ctrl->val & 0xff00) >> 8; -- dev->colourfx.enable = ctrl->val & 0xff; -+ dev->colourfx.u = (ctrl->val & 0xff00) >> 8; -+ dev->colourfx.v = ctrl->val & 0xff; - - ret = vchiq_mmal_port_parameter_set(dev->instance, control, - MMAL_PARAMETER_COLOUR_EFFECT,