Setting up DSA bond silently fails if mode is not 802.3ad. Add log message
to fix it. As we are already here harmonize all logging messages in the
add/delete functions.
Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
int i;
u32 algomsk = 0;
u32 algoidx = 0;
int i;
u32 algomsk = 0;
u32 algoidx = 0;
if (info->tx_type != NETDEV_LAG_TX_TYPE_HASH) {
if (info->tx_type != NETDEV_LAG_TX_TYPE_HASH) {
+ pr_err("%s: Only mode LACP 802.3ad (4) allowed.\n", __func__);
- pr_info("%s: Adding port %d to LA-group %d\n", __func__, port, group);
if (group >= priv->n_lags) {
if (group >= priv->n_lags) {
- pr_err("Link Agrregation group too large.\n");
+ pr_err("%s: LAG %d invalid.\n", __func__, group);
return -EINVAL;
}
if (port >= priv->cpu_port) {
return -EINVAL;
}
if (port >= priv->cpu_port) {
- pr_err("Invalid port number.\n");
+ pr_err("%s: Port %d invalid.\n", __func__, port);
break;
}
if (i != priv->n_lags) {
break;
}
if (i != priv->n_lags) {
- pr_err("%s: Port already member of LAG: %d\n", __func__, i);
+ pr_err("%s: Port %d already member of LAG %d.\n", __func__, port, i);
return -ENOSPC;
}
switch(info->hash_type) {
return -ENOSPC;
}
switch(info->hash_type) {
priv->r->mask_port_reg_be(0, BIT_ULL(port), priv->r->trk_mbr_ctr(group));
priv->lags_port_members[group] |= BIT_ULL(port);
priv->r->mask_port_reg_be(0, BIT_ULL(port), priv->r->trk_mbr_ctr(group));
priv->lags_port_members[group] |= BIT_ULL(port);
- pr_debug("lags_port_members %d now %016llx\n", group, priv->lags_port_members[group]);
+ pr_info("%s: Added port %d to LAG %d. Members now %016llx.\n",
+ __func__, port, group, priv->lags_port_members[group]);
{
struct rtl838x_switch_priv *priv = ds->priv;
{
struct rtl838x_switch_priv *priv = ds->priv;
- pr_info("%s: Removing port %d from LA-group %d\n", __func__, port, group);
-
if (group >= priv->n_lags) {
if (group >= priv->n_lags) {
- pr_err("Link Agrregation group too large.\n");
+ pr_err("%s: LAG %d invalid.\n", __func__, group);
return -EINVAL;
}
if (port >= priv->cpu_port) {
return -EINVAL;
}
if (port >= priv->cpu_port) {
- pr_err("Invalid port number.\n");
+ pr_err("%s: Port %d invalid.\n", __func__, port);
if (!(priv->lags_port_members[group] & BIT_ULL(port))) {
if (!(priv->lags_port_members[group] & BIT_ULL(port))) {
- pr_err("%s: Port not member of LAG: %d\n", __func__, group);
+ pr_err("%s: Port %d not member of LAG %d.\n", __func__, port, group);
// 0x7f algo mask all
priv->r->mask_port_reg_be(BIT_ULL(port), 0, priv->r->trk_mbr_ctr(group));
priv->lags_port_members[group] &= ~BIT_ULL(port);
// 0x7f algo mask all
priv->r->mask_port_reg_be(BIT_ULL(port), 0, priv->r->trk_mbr_ctr(group));
priv->lags_port_members[group] &= ~BIT_ULL(port);
- pr_info("lags_port_members %d now %016llx\n", group, priv->lags_port_members[group]);
+ pr_info("%s: Removed port %d from LAG %d. Members now %016llx.\n",
+ __func__, port, group, priv->lags_port_members[group]);