diff options
| author | Petr Štetiar | 2020-10-13 13:18:44 +0000 |
|---|---|---|
| committer | Petr Štetiar | 2020-10-13 13:27:49 +0000 |
| commit | 1fa034c65cb64deba51f0be993e5d3194ce4b0fc (patch) | |
| tree | e01fc1086306084333b0c0bb62e4f4f4affb766c | |
| parent | 3a67ebe3fc66ccc84b22eab317110e66b194045d (diff) | |
| download | mdnsd-1fa034c65cb64deba51f0be993e5d3194ce4b0fc.tar.gz | |
interface: fix value stored to 'fd' is never read
Fixes following issue reported by clang-12 static analyzer:
mdnsd/interface.c:360:3: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
mdnsd/interface.c:394:3: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
Original author most likely wanted to assing -1 to the original
interface filedescriptor.
Signed-off-by: Petr Štetiar <ynezz@true.cz>
| -rw-r--r-- | interface.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/interface.c b/interface.c index d3f2ad3..690e857 100644 --- a/interface.c +++ b/interface.c @@ -357,7 +357,7 @@ interface_mcast_setup4(struct interface *iface) if (setsockopt(fd, IPPROTO_IP, IP_ADD_MEMBERSHIP, &mreq, sizeof(mreq)) < 0) { fprintf(stderr, "failed to join multicast group: %m\n"); close(fd); - fd = -1; + iface->fd.fd = -1; return -1; } @@ -391,7 +391,7 @@ interface_socket_setup6(struct interface *iface) if (setsockopt(fd, IPPROTO_IPV6, IPV6_ADD_MEMBERSHIP, &mreq, sizeof(mreq)) < 0) { fprintf(stderr, "failed to join multicast group: %m\n"); close(fd); - fd = -1; + iface->fd.fd = -1; return -1; } |