summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Golle2021-08-13 18:14:12 +0000
committerDaniel Golle2021-08-14 17:58:45 +0000
commit2562e2b38d14fb1f337202feb6376fd447f30222 (patch)
tree9f25a6487c6ad44429e3f98770401313848896e6
parent459b3e84ef820137b106106155c1c26ea7414e6d (diff)
downloadprocd-2562e2b38d14fb1f337202feb6376fd447f30222.tar.gz
ujail-console: add missing error handling discovered by coverity
Coverity CID: 1490106 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
-rw-r--r--jail/console.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/jail/console.c b/jail/console.c
index 588d241..498756f 100644
--- a/jail/console.c
+++ b/jail/console.c
@@ -163,9 +163,16 @@ int main(int argc, char **argv)
ubus_free(ctx);
return -1;
}
-
setup_tios(server_fd, &oldtermios);
+
tty_fd = open("/dev/tty", O_RDWR);
+ if (tty_fd < 0) {
+ fprintf(stderr, "can't open local console!\n");
+ close(server_fd);
+ close(client_fd);
+ ubus_free(ctx);
+ return -1;
+ }
setup_tios(tty_fd, &oldtermios);
/* register server-side with procd */