summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFelix Fietkau2024-06-14 12:43:39 +0000
committerHauke Mehrtens2024-07-08 19:13:25 +0000
commit287e2565e2a4caccc8e04505585ba9e64b7e244b (patch)
tree45a148f1876147e739d5eb666c84bb90e3d46381
parent80a36594f9623dc471c6d866d3e688da39c143be (diff)
downloadopenwrt-287e2565e2a4caccc8e04505585ba9e64b7e244b.tar.gz
hostapd: fix crash on interface setup failure
Add a missing NULL pointer check when deleting beacons Signed-off-by: Felix Fietkau <nbd@nbd.name> (cherry picked from commit 3984fb0582083c5c0f511ed3a33eb17908eccb08) Link: https://github.com/openwrt/openwrt/pull/15898 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
-rw-r--r--package/network/services/hostapd/patches/060-nl80211-fix-crash-when-adding-an-interface-fails.patch21
1 files changed, 21 insertions, 0 deletions
diff --git a/package/network/services/hostapd/patches/060-nl80211-fix-crash-when-adding-an-interface-fails.patch b/package/network/services/hostapd/patches/060-nl80211-fix-crash-when-adding-an-interface-fails.patch
new file mode 100644
index 0000000000..44ba6c009c
--- /dev/null
+++ b/package/network/services/hostapd/patches/060-nl80211-fix-crash-when-adding-an-interface-fails.patch
@@ -0,0 +1,21 @@
+From: Felix Fietkau <nbd@nbd.name>
+Date: Fri, 14 Jun 2024 14:41:16 +0200
+Subject: [PATCH] nl80211: fix crash when adding an interface fails
+
+When adding an interface fails early, the bss link is still NULL.
+Avoid crashing on deleting beacons.
+
+Signed-off-by: Felix Fietkau <nbd@nbd.name>
+---
+
+--- a/src/drivers/driver_nl80211.c
++++ b/src/drivers/driver_nl80211.c
+@@ -3004,7 +3004,7 @@ static int wpa_driver_nl80211_del_beacon
+ struct nl_msg *msg;
+ struct wpa_driver_nl80211_data *drv = bss->drv;
+
+- if (!link->beacon_set)
++ if (!link || !link->beacon_set)
+ return 0;
+
+ wpa_printf(MSG_DEBUG, "nl80211: Remove beacon (ifindex=%d)",