diff options
| author | Qingfang Deng | 2024-06-28 09:01:00 +0000 |
|---|---|---|
| committer | Chuanhong Guo | 2024-07-07 12:59:48 +0000 |
| commit | 2ded54972e5acb6df8c323a173a4d8ff27f9f1a0 (patch) | |
| tree | 0e9528285cddd193c90bc9810d93f04d3bc77ae9 | |
| parent | 7117ebab0bc681aa6657202dd44c6b562335901b (diff) | |
| download | openwrt-2ded54972e5acb6df8c323a173a4d8ff27f9f1a0.tar.gz | |
mediatek: fit: fix use of uninitialized variable
When building the kernel with -Wmaybe-uninitialized, GCC reports this
warning:
block/partitions/fit.c: In function 'parse_fit_partitions':
block/partitions/fit.c:164:3: warning: 'images' may be used uninitialized in this function [-Wmaybe-uninitialized]
164 | printk(KERN_ERR "FIT: Cannot find %s node: %d\n", FIT_CONFS_PATH, images);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
It appears to be a copy paste error. It's the "config" variable that is
supposed to be printed.
Fixes: e6aac8d98f56 ("image: add support for building FIT image with filesystem")
Signed-off-by: Qingfang Deng <qingfang.deng@siflower.com.cn>
| -rw-r--r-- | target/linux/mediatek/files/block/partitions/fit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target/linux/mediatek/files/block/partitions/fit.c b/target/linux/mediatek/files/block/partitions/fit.c index 463cd4e9ab..01b0f42c7c 100644 --- a/target/linux/mediatek/files/block/partitions/fit.c +++ b/target/linux/mediatek/files/block/partitions/fit.c @@ -161,7 +161,7 @@ int parse_fit_partitions(struct parsed_partitions *state, u64 fit_start_sector, config = fdt_path_offset(fit, FIT_CONFS_PATH); if (config < 0) { - printk(KERN_ERR "FIT: Cannot find %s node: %d\n", FIT_CONFS_PATH, images); + printk(KERN_ERR "FIT: Cannot find %s node: %d\n", FIT_CONFS_PATH, config); ret = -ENOENT; goto ret_out; } |