summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStijn Tintel2021-11-25 03:41:16 +0000
committerStijn Tintel2022-01-06 12:49:15 +0000
commit31c7550efcb8d1f6014202a257fc1b9e3ab5fc9e (patch)
tree03c646b6e2d7f23485f3740955e098e6fd450f70
parent38889b77cc6f59eefd640b19f33e55efb53965aa (diff)
downloadfirewall4-31c7550efcb8d1f6014202a257fc1b9e3ab5fc9e.tar.gz
fw4.uc: do not skip defaults with invalid option
Skipping a defaults section because it contains invalid options can be a security risk. If the user configures a default policy to DROP or REJECT, this should always be applied. The user is warned about the invalid option anyway. This makes firewall4 behave like firewall3 with regards to defaults. Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be> Reviewed-by: Jo-Philipp Wich <jo@mein.io>
-rw-r--r--root/usr/share/ucode/fw4.uc5
1 files changed, 0 insertions, 5 deletions
diff --git a/root/usr/share/ucode/fw4.uc b/root/usr/share/ucode/fw4.uc
index 4769827..8057fac 100644
--- a/root/usr/share/ucode/fw4.uc
+++ b/root/usr/share/ucode/fw4.uc
@@ -1642,11 +1642,6 @@ return {
flow_offloading_hw: [ "bool", "0" ]
});
- if (defs === false) {
- this.warn_section(data, "skipped due to invalid options");
- return;
- }
-
if (defs.synflood_protect === null)
defs.synflood_protect = defs.syn_flood;