diff options
| author | Petr Štetiar | 2020-10-12 15:40:19 +0000 |
|---|---|---|
| committer | Petr Štetiar | 2020-10-13 13:27:49 +0000 |
| commit | 4cece9cc7db428fa0e1af27d4dced91bf7c2cc50 (patch) | |
| tree | 044de5538417ee3935c6e36e04c5faee751b17b2 | |
| parent | be687257ee0bef2a06c37de71664fbc74122ff6c (diff) | |
| download | mdnsd-4cece9cc7db428fa0e1af27d4dced91bf7c2cc50.tar.gz | |
cache: cache_record_find: fix buffer overflow
Fixes following buffer overflow:
ERROR: AddressSanitizer: global-buffer-overflow on address 0x0000007338b8 at pc 0x0000004db339 bp 0x7ffe370e6140 sp 0x7ffe370e6138
READ of size 8 at 0x0000007338b8 thread T0
#0 0x4db338 in cache_record_find mdnsd/cache.c:197:17
#1 0x4d74b4 in cache_answer mdnsd/cache.c:336:6
#2 0x4cf04a in parse_answer mdnsd/dns.c:343:3
#3 0x4cb272 in dns_handle_packet mdnsd/dns.c:442:7
#4 0x4f508c in read_socket4 mdnsd/interface.c:253:3
#5 0x7fb81dddc73d in uloop_run_events libubox/uloop.c:198:4
#6 0x7fb81dddc73d in uloop_run_timeout libubox/uloop.c:555:3
#7 0x4c77cd in uloop_run libubox/uloop.h:111:9
#8 0x4c7757 in main mdnsd/main.c:99:2
0x0000007338b8 is located 8 bytes to the right of global variable 'records' defined in 'mdnsd/cache.c:45:1' (0x733880) of size 48
SUMMARY: AddressSanitizer: global-buffer-overflow mdnsd/cache.c:197:17 in cache_record_find
Signed-off-by: Petr Štetiar <ynezz@true.cz>
| -rw-r--r-- | cache.c | 2 | ||||
| -rw-r--r-- | tests/fuzz/corpus/crash-68e33cae6500804f6856f5a92dca26626ad0479c | bin | 0 -> 69 bytes |
2 files changed, 1 insertions, 1 deletions
@@ -194,7 +194,7 @@ cache_record_find(char *record, int type, int port, int rdlength, uint8_t *rdata if (!l) return NULL; - while (l && l->record && !strcmp(l->record, record)) { + while (l && !avl_is_last(&records, &l->avl) && !strcmp(l->record, record)) { struct cache_record *r = l; l = avl_next_element(l, avl); diff --git a/tests/fuzz/corpus/crash-68e33cae6500804f6856f5a92dca26626ad0479c b/tests/fuzz/corpus/crash-68e33cae6500804f6856f5a92dca26626ad0479c Binary files differnew file mode 100644 index 0000000..69cd85b --- /dev/null +++ b/tests/fuzz/corpus/crash-68e33cae6500804f6856f5a92dca26626ad0479c |