summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRany Hany2025-11-24 15:00:57 +0000
committerRobert Marko2025-11-25 10:44:29 +0000
commit63c146a464da4fe72a4eb82ad6fe6da826a5dd43 (patch)
tree3644d8c617e9adfea4541a5fd88b8971be0aaa11
parent31f5fc8fea89ab3ac73445412fee82569bf08d3d (diff)
downloadopenwrt-63c146a464da4fe72a4eb82ad6fe6da826a5dd43.tar.gz
wifi-scripts: ucode: fix wifi-vlan "network" option not working
The call to netifd.set_vlan(...) had an incorrect argument order. It should be (interface, ifname, vlan) not (interface, vlan, ifname). This prevented wifi-vlan's "network" option from working as netifd was not able to find the wifi-vlan section. Fixes: https://github.com/openwrt/openwrt/issues/20705 Fixes: https://github.com/openwrt/openwrt/issues/20911 Signed-off-by: Rany Hany <rany_hany@riseup.net> Link: https://github.com/openwrt/openwrt/pull/20918 Signed-off-by: Robert Marko <robimarko@gmail.com>
-rw-r--r--package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc2
1 files changed, 1 insertions, 1 deletions
diff --git a/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc b/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc
index 1f1e27dbee..00aff02661 100644
--- a/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc
+++ b/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc
@@ -288,7 +288,7 @@ function iface_vlan(interface, config, vlans) {
if (vlan.config.name && vlan.config.vid) {
let ifname = `${config.ifname}-${vlan.config.name}`;
file.write(`${vlan.config.vid} ${ifname}\n`);
- netifd.set_vlan(interface, k, ifname);
+ netifd.set_vlan(interface, ifname, k);
}
file.close();