diff options
| author | Bjørn Mork | 2025-02-04 08:05:40 +0000 |
|---|---|---|
| committer | Sander Vanheule | 2025-02-25 19:53:30 +0000 |
| commit | 736229ba991ba69c6fdc7334353a43d9b1da1bdd (patch) | |
| tree | d8ff80b559c5cae96935144849cc005836e015ca | |
| parent | ef4b022150a44e4e6c565f8f2e73ffae9175d01e (diff) | |
| download | openwrt-736229ba991ba69c6fdc7334353a43d9b1da1bdd.tar.gz | |
realtek: sfp: prevent duplicate hwmon devices when re-probing on interface up
Re-probing on interface up will register a new duplicate hwmon device. Skip
the hwmon probe if we already have a sensor device.
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Link: https://github.com/openwrt/openwrt/pull/17950
Signed-off-by: Sander Vanheule <sander@svanheule.net>
| -rw-r--r-- | target/linux/realtek/patches-6.6/710-net-phy-sfp-re-probe-modules-on-DEV_UP-event.patch | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/target/linux/realtek/patches-6.6/710-net-phy-sfp-re-probe-modules-on-DEV_UP-event.patch b/target/linux/realtek/patches-6.6/710-net-phy-sfp-re-probe-modules-on-DEV_UP-event.patch index 4e1a21aa71..26216691e4 100644 --- a/target/linux/realtek/patches-6.6/710-net-phy-sfp-re-probe-modules-on-DEV_UP-event.patch +++ b/target/linux/realtek/patches-6.6/710-net-phy-sfp-re-probe-modules-on-DEV_UP-event.patch @@ -10,7 +10,18 @@ Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com> --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c -@@ -2416,6 +2416,13 @@ static void sfp_sm_module(struct sfp *sf +@@ -1557,6 +1557,10 @@ static void sfp_hwmon_probe(struct work_ + struct sfp *sfp = container_of(work, struct sfp, hwmon_probe.work); + int err; + ++ /* Avoid duplicate hwmon devices when re-probing */ ++ if (sfp->hwmon_dev) ++ return; ++ + /* hwmon interface needs to access 16bit registers in atomic way to + * guarantee coherency of the diagnostic monitoring data. If it is not + * possible to guarantee coherency because EEPROM is broken in such way +@@ -2416,6 +2420,13 @@ static void sfp_sm_module(struct sfp *sf return; } |