diff options
| author | Sven Eckelmann | 2025-11-23 14:10:41 +0000 |
|---|---|---|
| committer | Hauke Mehrtens | 2025-11-24 23:28:50 +0000 |
| commit | 80375e5acdaaf7555cd44ee1c8f247f701c6c5cb (patch) | |
| tree | fca971134716ab3ad92a21a15617cff2f37b2b79 | |
| parent | bc71e705aa03ccf97d1044e8c0f9e415413ca12c (diff) | |
| download | openwrt-80375e5acdaaf7555cd44ee1c8f247f701c6c5cb.tar.gz | |
realtek: ethernet: Avoid usage of unsafe strcpy
strcpy doesn't check the length of the destination buffer. And strlcpy
would not make sure to null-terminate the destination buffer.
Even when it is clear that this string will fit in the currrent buffer, it
is just best practice to avoid strcpy.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Link: https://github.com/openwrt/openwrt/pull/20906
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
| -rw-r--r-- | target/linux/realtek/files-6.12/drivers/net/ethernet/rtl838x_eth.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/target/linux/realtek/files-6.12/drivers/net/ethernet/rtl838x_eth.c b/target/linux/realtek/files-6.12/drivers/net/ethernet/rtl838x_eth.c index d9c0fb16a3..91ea29d6c0 100644 --- a/target/linux/realtek/files-6.12/drivers/net/ethernet/rtl838x_eth.c +++ b/target/linux/realtek/files-6.12/drivers/net/ethernet/rtl838x_eth.c @@ -1798,7 +1798,8 @@ static int __init rtl838x_eth_probe(struct platform_device *pdev) } pr_info("Using MAC %08x%08x\n", sw_r32(priv->r->mac), sw_r32(priv->r->mac + 4)); - strcpy(dev->name, "eth%d"); + strscpy(dev->name, "eth%d", sizeof(dev->name)); + priv->pdev = pdev; priv->netdev = dev; |