summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLeon M. Busch-George2024-10-19 10:03:08 +0000
committerJohn Crispin2024-12-12 08:46:38 +0000
commit821ebce8c115f8670eb0dd83e45efc2a15d3469f (patch)
tree42479afed2e61939612a92470ba4c7d71d2e67af
parent650410fca4596328d0ec75cefd7e1b202e896a48 (diff)
downloadopenwrt-821ebce8c115f8670eb0dd83e45efc2a15d3469f.tar.gz
mbim: sort config variables a little and fix minor bugs
Group 'local' declarations and 'json_get_vars', sort alphabetically within groups, and split off more generic parameters. - delegate and sourcefilter were not declared as local variables Signed-off-by: Leon M. Busch-George <leon@georgemail.eu> Link: https://github.com/openwrt/openwrt/pull/16734 Signed-off-by: John Crispin <john@phrozen.org>
-rwxr-xr-xpackage/network/utils/umbim/files/lib/netifd/proto/mbim.sh12
1 files changed, 8 insertions, 4 deletions
diff --git a/package/network/utils/umbim/files/lib/netifd/proto/mbim.sh b/package/network/utils/umbim/files/lib/netifd/proto/mbim.sh
index 75b914e8aa..01e8628d74 100755
--- a/package/network/utils/umbim/files/lib/netifd/proto/mbim.sh
+++ b/package/network/utils/umbim/files/lib/netifd/proto/mbim.sh
@@ -46,10 +46,14 @@ _proto_mbim_setup() {
local tid=2
local ret
- local device apn pincode delay auth username password allow_roaming allow_partner
- local dhcp dhcpv6 pdptype ip4table ip6table mtu $PROTO_DEFAULT_OPTIONS
- json_get_vars device apn pincode delay auth username password allow_roaming allow_partner
- json_get_vars dhcp dhcpv6 sourcefilter delegate pdptype ip4table ip6table mtu $PROTO_DEFAULT_OPTIONS
+ local allow_partner allow_roaming apn auth delay device password pincode username
+ json_get_vars allow_partner allow_roaming apn auth delay device password pincode username
+
+ local dhcp dhcpv6 pdptype
+ json_get_vars dhcp dhcpv6 pdptype
+
+ local delegate ip4table ip6table mtu sourcefilter $PROTO_DEFAULT_OPTIONS
+ json_get_vars delegate ip4table ip6table mtu sourcefilter $PROTO_DEFAULT_OPTIONS
[ ! -e /proc/sys/net/ipv6 ] && ipv6=0 || json_get_var ipv6 ipv6