Merge pull request #6862 from jesferman/fix_11r_dependencies
authorJo-Philipp Wich <jo@mein.io>
Tue, 23 Jan 2024 16:36:29 +0000 (17:36 +0100)
committerGitHub <noreply@github.com>
Tue, 23 Jan 2024 16:36:29 +0000 (17:36 +0100)
luci-mod-network: wireless.js: fix 802.11r dependencies

modules/luci-mod-network/htdocs/luci-static/resources/view/network/wireless.js

index 80ab426a0eea189d953cb238e160c231ac610123..e51eb023c853f2074313dd277c4861906864c33b 100644 (file)
@@ -1548,9 +1548,9 @@ return view.extend({
                                        var has_80211r = L.hasSystemFeature('hostapd', '11r') || L.hasSystemFeature('hostapd', 'eap');
 
                                        o = ss.taboption('roaming', form.Flag, 'ieee80211r', _('802.11r Fast Transition'), _('Enables fast roaming among access points that belong to the same Mobility Domain'));
-                                       add_dependency_permutations(o, { mode: ['ap', 'ap-wds'], encryption: ['wpa', 'wpa2', 'wpa3', 'wpa3-mixed'] });
+                                       add_dependency_permutations(o, { mode: ['ap', 'ap-wds'], encryption: ['wpa2', 'wpa3', 'wpa3-mixed'] });
                                        if (has_80211r)
-                                               add_dependency_permutations(o, { mode: ['ap', 'ap-wds'], encryption: ['psk', 'psk2', 'psk-mixed', 'sae', 'sae-mixed'] });
+                                               add_dependency_permutations(o, { mode: ['ap', 'ap-wds'], encryption: ['psk2', 'psk-mixed', 'sae', 'sae-mixed'] });
                                        o.rmempty = true;
 
                                        o = ss.taboption('roaming', form.Value, 'nasid', _('NAS ID'), _('Used for two different purposes: RADIUS NAS ID and 802.11r R0KH-ID. Not needed with normal WPA(2)-PSK.'));
@@ -1577,7 +1577,7 @@ return view.extend({
                                        o.rmempty = true;
 
                                        o = ss.taboption('roaming', form.Flag, 'ft_psk_generate_local', _('Generate PMK locally'), _('When using a PSK, the PMK can be automatically generated. When enabled, the R0/R1 key options below are not applied. Disable this to use the R0 and R1 key options.'));
-                                       o.depends({ ieee80211r: '1' });
+                                       add_dependency_permutations(o, { ieee80211r: ['1'], mode: ['ap', 'ap-wds'], encryption: ['psk2', 'psk-mixed'] });
                                        o.default = o.enabled;
                                        o.rmempty = false;