diff options
| author | Daniel Golle | 2021-08-23 17:11:08 +0000 |
|---|---|---|
| committer | Daniel Golle | 2021-08-24 17:32:01 +0000 |
| commit | d716cb5ca3c27e7bff2ab6f793aa4b827fdd3290 (patch) | |
| tree | 3975616d534f77db51a58b9da95d624393229886 | |
| parent | 51f1cd2366ebfc1f4ebbbfc819d36086ed3b5eb9 (diff) | |
| download | procd-d716cb5ca3c27e7bff2ab6f793aa4b827fdd3290.tar.gz | |
trace: handle open() return value and make sure string is terminated
Coverity CID: 1446154 Argument cannot be negative
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
| -rw-r--r-- | trace/trace.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/trace/trace.c b/trace/trace.c index eec21f8..8d90b5e 100644 --- a/trace/trace.c +++ b/trace/trace.c @@ -184,7 +184,12 @@ static void report_seccomp_vialation(pid_t pid, unsigned syscall) char buf[200]; snprintf(buf, sizeof(buf), "/proc/%d/cmdline", pid); int f = open(buf, O_RDONLY); + if (f < 0) + return; + int r = read(f, buf, sizeof(buf) - 1); + buf[sizeof(buf) - 1] = '\0'; + if (r >= 0) buf[r] = 0; else |