From: Daniel Golle <daniel@makrotopia.org>
Date: Mon, 23 Aug 2021 16:41:57 +0000 (+0100)
Subject: jail: return to hook callback instead of just calling it
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=0603c8d5b0039d28ba1ac6ce64a6a5814aa0bf24;p=project%2Fprocd.git

jail: return to hook callback instead of just calling it

Avoid stack pollution and potentially worse things.

Coverity CID: 1490056 Dereference after null check

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---

diff --git a/jail/jail.c b/jail/jail.c
index d61bbe0..24a3df3 100644
--- a/jail/jail.c
+++ b/jail/jail.c
@@ -457,7 +457,7 @@ static void run_hooklist(void)
 	struct stat s;
 
 	if (!hook)
-		hook_return_cb();
+		return hook_return_cb();
 
 	DEBUG("executing hook %s\n", hook->file);