From: Ramon Van Gorkom <Ramon00c00@gmail.com>
Date: Mon, 29 Apr 2024 16:45:18 +0000 (+0200)
Subject: luci-app-usteer: Allow editing of settings if usteer is not running
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=3815d4fc0714169a18763352b6a9c70aef3adcf8;p=project%2Fluci.git

luci-app-usteer: Allow editing of settings if usteer is not running

Apparently, an invalid parameter can stop usteer from starting.  This PR allows the editing of parameters while usteer is stopped. In that case the status tab is not shown.

Signed-off-by: Ramon Van Gorkom <Ramon00c00@gmail.com>
---

diff --git a/applications/luci-app-usteer/htdocs/luci-static/resources/view/usteer/usteer.js b/applications/luci-app-usteer/htdocs/luci-static/resources/view/usteer/usteer.js
index 166ebcef4b..48ec283b61 100644
--- a/applications/luci-app-usteer/htdocs/luci-static/resources/view/usteer/usteer.js
+++ b/applications/luci-app-usteer/htdocs/luci-static/resources/view/usteer/usteer.js
@@ -368,13 +368,15 @@ return view.extend({
 
 		if (!('usteer' in data[0])) {
 			m = new form.Map('usteer', _('Usteer'),
-				_('Usteer is not running. Make sure it is installed and running.') +
+				_('Usteer is not running. Make sure it is installed and running.') +' '+
+				_('An incorrect parameter can cause usteer to fail to start up.') +' '+
 				_('To start it running try %s').format('<code>/etc/init.d/usteer start</code>')
 			);
-			return m.render();
 		}
 
-		m = new form.Map('usteer', _('Usteer'));
+		else {
+			m = new form.Map('usteer', _('Usteer'));
+		}
 
 		Hosts = data[1];
 		Remotehosts = data[2];
@@ -389,11 +391,13 @@ return view.extend({
 		s.tab('hearingmap', _('Hearing map'));
 		s.tab('settings', _('Settings'));
 
-		o = s.taboption('status', Clientinfooverview);
-		o.readonly = true;
+		if (('usteer' in data[0])) {
+			o = s.taboption('status', Clientinfooverview);
+			o.readonly = true;
 
-		o = s.taboption('hearingmap', HearingMap);
-		o.readonly = true;
+			o = s.taboption('hearingmap', HearingMap);
+			o.readonly = true;
+		}
 
 		o = s.taboption('settings', Settingstitle);
 		o.readonly = true;