From: Hannu Nyman Date: Wed, 31 Dec 2025 19:45:30 +0000 (+0200) Subject: php8: revert "php8: fix PHP8_GETTEXT missing icu dependency" X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=7e25efa101a7c6cfed90538eefca78a2c3ee3a18;p=feed%2Fpackages.git php8: revert "php8: fix PHP8_GETTEXT missing icu dependency" This reverts commit 996046e642426f900809d07f5bedb6f2807f0816. After that faulty commit the 'icu' package is always selected even if php8 itself is not even selected. Simple bug reproduction process: perus@ub2510:/OpenWrt/aarch64$ rm .config perus@ub2510:/OpenWrt/aarch64$ touch .config perus@ub2510:/OpenWrt/aarch64$ make defconfig Collecting package info: done ... # # configuration written to .config # perus@ub2510:/OpenWrt/aarch64$ grep -iE "php8|icu" .config # PHP8 # CONFIG_PACKAGE_php8 is not set CONFIG_PHP8_LIBXML=y CONFIG_PHP8_DOM=y CONFIG_PHP8_GETTEXT=y CONFIG_PHP8_INTL=y # CONFIG_PHP8_FULLICUDATA is not set # end of PHP8 CONFIG_PACKAGE_icu=y # CONFIG_PACKAGE_icu-data-tools is not set # CONFIG_PACKAGE_icu-full-data is not set Revert the commit, so that a fix can be developed and tested. Signed-off-by: Hannu Nyman --- diff --git a/lang/php8/Makefile b/lang/php8/Makefile index 8271421a9a..70c45f93e3 100644 --- a/lang/php8/Makefile +++ b/lang/php8/Makefile @@ -81,7 +81,6 @@ define Package/php8/config config PHP8_GETTEXT bool "Enable gettext" - select PACKAGE_icu default y config PHP8_INTL