From: tew42 <2049715+tew42@users.noreply.github.com> Date: Sun, 2 Jan 2022 09:45:18 +0000 (+0200) Subject: luci-app-statistics: ping module, Update MaxMissed data type X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=8572ae032f336f49eb9ed5c3843bce57542c0c05;p=project%2Fluci.git luci-app-statistics: ping module, Update MaxMissed data type MaxMissed was implemented with positive integers only, whereas I think it should also allow the option of "-1" (disabled state) Signed-off-by: tew42 <2049715+tew42@users.noreply.github.com> [slightly edited the proposed text] Signed-off-by: Hannu Nyman --- diff --git a/applications/luci-app-statistics/htdocs/luci-static/resources/view/statistics/plugins/ping.js b/applications/luci-app-statistics/htdocs/luci-static/resources/view/statistics/plugins/ping.js index e08ff6497b..0c827e8a0b 100644 --- a/applications/luci-app-statistics/htdocs/luci-static/resources/view/statistics/plugins/ping.js +++ b/applications/luci-app-statistics/htdocs/luci-static/resources/view/statistics/plugins/ping.js @@ -34,9 +34,9 @@ return baseclass.extend({ o.depends('enable', '1'); o=s.option(form.Value,'MaxMissed',_('Maximum Missed Packets'), - _('When a host has not replied to this number of packets in a row, re-resolve the hostname in DNS. Useful for dynamic DNS hosts.')); - o.placeholder = '10'; - o.datatype = 'uinteger'; + _('When a host has not replied to this number of packets in a row, re-resolve the hostname in DNS. Useful for dynamic DNS hosts. Default is -1 = disabled.')); + o.placeholder = '-1'; + o.datatype = 'and(min(-1),integer)' o.optional = true; o.depends('enable', '1'); },