From: Gabor Juhos <juhosg@openwrt.org>
Date: Sat, 30 Jan 2010 15:25:12 +0000 (+0000)
Subject: rtl8366_smi: sanitize gpio values to a 0/1 boolean
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=8b66cede29af1cc01c0b4eacc55b2e968db83513;p=openwrt%2Fsvn-archive%2Farchive.git

rtl8366_smi: sanitize gpio values to a 0/1 boolean


SVN-Revision: 19402
---

diff --git a/target/linux/generic-2.6/files/drivers/net/phy/rtl8366_smi.c b/target/linux/generic-2.6/files/drivers/net/phy/rtl8366_smi.c
index 70218fc6ca..7091190b8d 100644
--- a/target/linux/generic-2.6/files/drivers/net/phy/rtl8366_smi.c
+++ b/target/linux/generic-2.6/files/drivers/net/phy/rtl8366_smi.c
@@ -91,10 +91,7 @@ static void rtl8366_smi_write_bits(struct rtl8366_smi *smi, u32 data, u32 len)
 		rtl8366_smi_clk_delay(smi);
 
 		/* prepare data */
-		if ( data & ( 1 << (len - 1)) )
-			gpio_set_value(sda, 1);
-		else
-			gpio_set_value(sda, 0);
+		gpio_set_value(sda, !!(data & ( 1 << (len - 1))));
 		rtl8366_smi_clk_delay(smi);
 
 		/* clocking */
@@ -119,7 +116,7 @@ static void rtl8366_smi_read_bits(struct rtl8366_smi *smi, u32 len, u32 *data)
 		/* clocking */
 		gpio_set_value(sck, 1);
 		rtl8366_smi_clk_delay(smi);
-		u = gpio_get_value(sda);
+		u = !!gpio_get_value(sda);
 		gpio_set_value(sck, 0);
 
 		*data |= (u << (len - 1));