From: Jo-Philipp Wich <jow@openwrt.org>
Date: Sat, 20 Nov 2010 17:23:44 +0000 (+0000)
Subject: applications/luci-firewall: some fixes on redirection page
X-Git-Tag: 0.10.0~405
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=aa0f710867cc4333df4efa3fdb45ae2ed51e9c50;p=project%2Fluci.git

applications/luci-firewall: some fixes on redirection page
---

diff --git a/applications/luci-firewall/luasrc/model/cbi/luci_fw/rrule.lua b/applications/luci-firewall/luasrc/model/cbi/luci_fw/rrule.lua
index 5769c1da0c..65e3e5816d 100644
--- a/applications/luci-firewall/luasrc/model/cbi/luci_fw/rrule.lua
+++ b/applications/luci-firewall/luasrc/model/cbi/luci_fw/rrule.lua
@@ -66,7 +66,7 @@ src.nocreate = true
 src.default = "wan"
 src.template = "cbi/firewall_zonelist"
 
-proto = s:taboption("general", ListValue, "proto", translate("Protocol"))
+proto = s:taboption("general", Value, "proto", translate("Protocol"))
 proto.optional = true
 proto:value("tcpudp", "TCP+UDP")
 proto:value("tcp", "TCP")
@@ -93,6 +93,10 @@ toport = s:taboption("general", Value, "dest_port", translate("Internal port (op
 		"the internal host"))
 toport.optional = true
 toport.placeholder = "0-65535"
+toport.datatype = "portrange"
+toport:depends("proto", "tcp")
+toport:depends("proto", "udp")
+toport:depends("proto", "tcpudp")
 
 target = s:taboption("advanced", ListValue, "target", translate("Redirection type"))
 target:value("DNAT")