From: Stijn Tintel <stijn@linux-ipv6.be>
Date: Mon, 13 Jun 2022 08:05:10 +0000 (+0300)
Subject: fw4.uc: don't skip zone for unavailable helper
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=b9d35ff6b495465413a81622e849076a9e1fa690;p=project%2Ffirewall4.git

fw4.uc: don't skip zone for unavailable helper

Skipping a zone because a configured helper is not available is a bigger
security risk than not setting up the helper, as a zone might have
stricter settings than the defaults

Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
---

diff --git a/root/usr/share/ucode/fw4.uc b/root/usr/share/ucode/fw4.uc
index a338446..0200758 100644
--- a/root/usr/share/ucode/fw4.uc
+++ b/root/usr/share/ucode/fw4.uc
@@ -1884,8 +1884,7 @@ return {
 
 		for (let helper in zone.helper) {
 			if (!helper.available) {
-				this.warn_section(data, `uses unavailable ct helper '${zone.helper.name}', ignoring section`);
-				return;
+				this.warn_section(data, `uses unavailable ct helper '${zone.helper.name}'`);
 			}
 		}