From: Sven Wegener Date: Sat, 12 Jun 2021 19:56:21 +0000 (+0200) Subject: mediatek: cast literal value to char X-Git-Tag: v23.05.0-rc1~2479 X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=e9a22ce2535c4a0faf83d5595304fe0e2c7bd1b2;p=openwrt%2Fstaging%2Fhauke.git mediatek: cast literal value to char Or the comparison against a signed char is always true, because the literal 0xaa is treated as an unsigned int, to which the signed char is casted during comparison. 0xaa is above the positive values of a signed char and negative signed char values result in values larger than 0xaa when casted to unsigned int. Signed-off-by: Sven Wegener --- diff --git a/target/linux/mediatek/files/drivers/leds/leds-ubnt-ledbar.c b/target/linux/mediatek/files/drivers/leds/leds-ubnt-ledbar.c index 9bfe0e62f4..8168391d7e 100644 --- a/target/linux/mediatek/files/drivers/leds/leds-ubnt-ledbar.c +++ b/target/linux/mediatek/files/drivers/leds/leds-ubnt-ledbar.c @@ -26,7 +26,7 @@ #define UBNT_LEDBAR_MAX_BRIGHTNESS 0xff #define UBNT_LEDBAR_TRANSACTION_LENGTH 8 -#define UBNT_LEDBAR_TRANSACTION_SUCCESS 0xaa +#define UBNT_LEDBAR_TRANSACTION_SUCCESS (char) 0xaa #define UBNT_LEDBAR_TRANSACTION_BLUE_IDX 2 #define UBNT_LEDBAR_TRANSACTION_GREEN_IDX 3