From: Olliver Schinagl <oliver@schinagl.nl>
Date: Thu, 21 Mar 2024 08:41:54 +0000 (+0100)
Subject: scripts/kernel_bump: Improve omitted version error
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=ed896c32b09e3adfaa5fdda5c584ef776e395b09;hp=03f2f530a00a55e6580733cd6ccd01a018a473ee;p=openwrt%2Fstaging%2Fpepe2k.git

scripts/kernel_bump: Improve omitted version error

If a version string was not supplied, we currently print an empty
string. We can do better here. Also by popular demand, print the usage
information in case of error.

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
---

diff --git a/scripts/kernel_bump.sh b/scripts/kernel_bump.sh
index 82ee3f3eff..90e47789c3 100755
--- a/scripts/kernel_bump.sh
+++ b/scripts/kernel_bump.sh
@@ -205,7 +205,9 @@ main()
 	target_version="${target_version:-${TARGET_VERSION:-}}"
 
 	if [ -z "${source_version:-}" ] || [ -z "${target_version:-}" ]; then
-		e_err "Source (${source_version}) and target (${target_version}) versions need to be defined."
+		e_err "Source (${source_version:-missing source version}) and target (${target_version:-missing target version}) versions need to be defined."
+		echo
+		usage
 		exit 1
 	fi