From 0fd3a6c6c6f079565f1f5de4709f3d4d71fc54c8 Mon Sep 17 00:00:00 2001 From: Christian Marangi Date: Fri, 26 Jan 2024 16:14:20 +0100 Subject: [PATCH] CI: formal: use shared workflow in actions-shared-workflows Use shared workflow in actions-shared-workflows instead of keeping the workflow in openwrt main branch to make it easier to maintain and update without bloating the main repository commit history. Signed-off-by: Christian Marangi --- .github/workflows/formal.yml | 55 +----------------------------------- 1 file changed, 1 insertion(+), 54 deletions(-) diff --git a/.github/workflows/formal.yml b/.github/workflows/formal.yml index 1532591dfc..081129d6f0 100644 --- a/.github/workflows/formal.yml +++ b/.github/workflows/formal.yml @@ -9,57 +9,4 @@ permissions: jobs: build: name: Test Formalities - runs-on: ubuntu-latest - strategy: - fail-fast: false - - steps: - - uses: actions/checkout@v3 - with: - ref: ${{ github.event.pull_request.head.sha }} - fetch-depth: 0 - - - name: Determine branch name - run: | - BRANCH="${GITHUB_BASE_REF#refs/heads/}" - echo "Building for $BRANCH" - echo "BRANCH=$BRANCH" >> $GITHUB_ENV - - - name: Test formalities - run: | - source .github/workflows/scripts/ci_helpers.sh - - RET=0 - for commit in $(git rev-list HEAD ^origin/$BRANCH); do - info "=== Checking commit '$commit'" - if git show --format='%P' -s $commit | grep -qF ' '; then - err "Pull request should not include merge commits" - RET=1 - fi - - subject="$(git show -s --format=%s $commit)" - if echo "$subject" | grep -q -e '^[0-9A-Za-z,+/_\.-]\+: ' -e '^Revert '; then - success "Commit subject line seems ok ($subject)" - else - err "Commit subject line MUST start with ': ' ($subject)" - RET=1 - fi - - body="$(git show -s --format=%b $commit)" - sob="$(git show -s --format='Signed-off-by: %aN <%aE>' $commit)" - if echo "$body" | grep -qF "$sob"; then - success "Signed-off-by match author" - else - err "Signed-off-by is missing or doesn't match author (should be '$sob')" - RET=1 - fi - - if echo "$body" | grep -v "Signed-off-by:"; then - success "A commit message exists" - else - err "Missing commit message. Please describe your changes" - RET=1 - fi - done - - exit $RET + uses: openwrt/actions-shared-workflows/.github/workflows/formal.yml@main -- 2.30.2