From a66c08849a95ad653635b9d8aefe5a8ecb2382f8 Mon Sep 17 00:00:00 2001 From: Hannu Nyman Date: Wed, 28 Oct 2015 13:07:47 +0200 Subject: [PATCH] luci-app-firewall: limit zone name length to 11 characters Change the maximum length of a firewall zone name from 14 to 11 characters. Longer names break iptables rule generation (max. 29 chars are allowed). XT_EXTENSION_MAXNAMELEN = 29 29 - sizeof("postrouting_") - sizeof("_rule") - sizeof("\0") = 11 References to: https://github.com/openwrt/luci/issues/507 https://dev.openwrt.org/ticket/20380 Signed-off-by: Hannu Nyman (cherry picked from commit 87b6bb0dafbbe46dc7669356ac3db24aa975c4b7) --- .../luasrc/model/cbi/firewall/zone-details.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/applications/luci-app-firewall/luasrc/model/cbi/firewall/zone-details.lua b/applications/luci-app-firewall/luasrc/model/cbi/firewall/zone-details.lua index 6c90476f81..c8b8f22bda 100644 --- a/applications/luci-app-firewall/luasrc/model/cbi/firewall/zone-details.lua +++ b/applications/luci-app-firewall/luasrc/model/cbi/firewall/zone-details.lua @@ -60,7 +60,7 @@ s:tab("advanced", translate("Advanced Settings")) name = s:taboption("general", Value, "name", translate("Name")) name.optional = false name.forcewrite = true -name.datatype = "and(uciname,maxlength(14))" +name.datatype = "and(uciname,maxlength(11))" function name.write(self, section, value) if zone:name() ~= value then -- 2.30.2