babeld: Don't kill -9 on stop
authorBaptiste Jonglez <git@bitsofnetworks.org>
Mon, 26 Aug 2019 16:39:37 +0000 (18:39 +0200)
committerBaptiste Jonglez <git@bitsofnetworks.org>
Mon, 26 Aug 2019 16:40:35 +0000 (18:40 +0200)
Killing anything with -9 is a bad idea.  When killed this way, babeld
won't be able to properly disassociate from its neighbours, withdraw its
announced routes or remove routes from the kernel.

This got introduced in bab933d4cad8 ("babeld: Update to version 1.8.3 +
fix init") with an unrelated change.  The purpose of the change is unclear
because stopping and restarting babeld worked fine without this change.

Signed-off-by: Baptiste Jonglez <git@bitsofnetworks.org>
babeld/files/babeld.init

index 7b25ef4..378a8ab 100755 (executable)
@@ -197,10 +197,6 @@ start_service() {
        procd_close_instance
 }
 
-stop_service() {
-       killall -9 babeld
-}
-
 service_triggers() {
        procd_add_reload_trigger babeld
 }