package/kernel/mac80211/patches/319-0031-brcmfmac-replace-WARNING-on-timeout-with-a-simple-er.patch

   1 From 2f0e56fa37cce60a5ac5d451bcadec51cd711436 Mon Sep 17 00:00:00 2001
   2 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
   3 Date: Tue, 27 Sep 2016 12:12:24 +0200
   4 Subject: [PATCH] brcmfmac: replace WARNING on timeout with a simple error
   5  message
   6 MIME-Version: 1.0
   7 Content-Type: text/plain; charset=UTF-8
   8 Content-Transfer-Encoding: 8bit
   9
  10 Even with timeout increased to 950 ms we get WARNINGs from time to time.
  11 It mostly happens on A-MPDU stalls (e.g. when station goes out of
  12 range). It may take up to 5-10 secods for the firmware to recover and
  13 for that time it doesn't process packets.
  14
  15 It's still useful to have a message on time out as it may indicate some
  16 firmware problem and incorrect key update. Raising a WARNING however
  17 wasn't really that necessary, it doesn't point to any driver bug anymore
  18 and backtrace wasn't much useful.
  19
  20 Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
  21 Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
  22 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  23 ---
  24  drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 3 ++-
  25  1 file changed, 2 insertions(+), 1 deletion(-)
  26
  27 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
  28 +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
  29 @@ -1155,7 +1155,8 @@ int brcmf_netdev_wait_pend8021x(struct b
  30                                  !brcmf_get_pend_8021x_cnt(ifp),
  31                                  MAX_WAIT_FOR_8021X_TX);
  32
  33 -       WARN_ON(!err);
  34 +       if (!err)
  35 +               brcmf_err("Timed out waiting for no pending 802.1x packets\n");
  36
  37         return !err;
  38  }