allow the user to disable the defaultroute option for ppp
[openwrt/openwrt.git] / package / ppp / patches / 104-debian_fix_linkpidfile.patch
1 Subject: Bug#284382: ppp: linkpidfile is not created upon detachment
2 From: <herbert@gondor.apana.org.au>
3
4 Package: ppp
5 Version: 2.4.2+20040428-2
6 Severity: wishlist
7
8 When pppd detaches from the parent normally, that is, without nodetach
9 or updetach set, the linkpidfile is not created even when linkname is
10 set.
11
12 This is because the create_linkpidfile call in detach() is only made
13 if the linkpidfile is filled in. However, linkpidfile is never filled
14 in until create_linkpidfile has been called.
15
16 IMHO the call should be made uncondtionally in detach() since
17 create_linkpidfile does its own check on linkname anyway.
18
19 Please note that the version of pppd in woody always wrote the
20 linkpidfile after detaching. It did so in main() however. That
21 call has now been removed which is why I'm seeing this problem.
22
23 [...]
24
25 --
26 Index: ppp-2.4.3/pppd/main.c
27 ===================================================================
28 --- ppp-2.4.3.orig/pppd/main.c 2007-06-04 13:22:09.004486392 +0200
29 +++ ppp-2.4.3/pppd/main.c 2007-06-04 13:22:10.548251704 +0200
30 @@ -768,8 +768,7 @@
31 /* update pid files if they have been written already */
32 if (pidfilename[0])
33 create_pidfile(pid);
34 - if (linkpidfile[0])
35 - create_linkpidfile(pid);
36 + create_linkpidfile(pid);
37 exit(0); /* parent dies */
38 }
39 setsid();